chrome/browser/extensions/content_capabilities_browsertest.cc - Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/content_capabilities_browsertest.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)

Patch Set: Remove dependency CL. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/content_capabilities_browsertest.cc

diff --git a/chrome/browser/extensions/content_capabilities_browsertest.cc b/chrome/browser/extensions/content_capabilities_browsertest.cc

index dbc01bdb3f160864d87b60d2e6b7a5f2a148ba7b..c0149e2b2e6d7d5e682b102c449e5951fcd66e77 100644

--- a/chrome/browser/extensions/content_capabilities_browsertest.cc

+++ b/chrome/browser/extensions/content_capabilities_browsertest.cc

@@ -9,6 +9,7 @@

#include "base/files/file_util.h"

#include "base/path_service.h"

#include "base/strings/string_number_conversions.h"

+#include "base/strings/string_piece.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "chrome/browser/extensions/extension_apitest.h"

@@ -67,7 +68,7 @@ class ContentCapabilitiesTest : public ExtensionApiTest {

std::string MakeJSONList(const std::string& s0 = "",

const std::string& s1 = "",

const std::string& s2 = "") {

- std::vector<std::string> v;

+ std::vector<base::StringPiece> v;

if (!s0.empty())

v.push_back(s0);

if (!s1.empty())