Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Remove dependency CL. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_installer.cc
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
index 49cd7b69ff56637cb8bceaf9abbdd485ac1ffecc..feae1e5d18d1fec9c4db5d87c10435db6ad8ecf1 100644
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -20,6 +20,7 @@
#include "base/path_service.h"
#include "base/rand_util.h"
#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
@@ -213,10 +214,12 @@ GURL WebstoreInstaller::GetWebstoreInstallURL(
return GURL(base::StringPrintf(download_url.c_str(),
extension_id.c_str()));
}
- std::vector<std::string> params;
- params.push_back("id=" + extension_id);
+ std::vector<base::StringPiece> params;
+ std::string extension_param = "id=" + extension_id;
+ std::string installsource_param = "installsource=" + install_source;
+ params.push_back(extension_param);
if (!install_source.empty())
- params.push_back("installsource=" + install_source);
+ params.push_back(installsource_param);
params.push_back("uc");
std::string url_string = extension_urls::GetWebstoreUpdateUrl().spec();
« no previous file with comments | « chrome/browser/extensions/content_capabilities_browsertest.cc ('k') | chrome/browser/net/safe_search_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698