Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: chrome/browser/extensions/chrome_content_verifier_delegate.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Remove dependency CL. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_content_verifier_delegate.cc
diff --git a/chrome/browser/extensions/chrome_content_verifier_delegate.cc b/chrome/browser/extensions/chrome_content_verifier_delegate.cc
index 5e1ea9918a0e07c4c52b0f9f91c3a5931305a16f..8dd2362599bc6fece91d8ca177d0f0907184ec5d 100644
--- a/chrome/browser/extensions/chrome_content_verifier_delegate.cc
+++ b/chrome/browser/extensions/chrome_content_verifier_delegate.cc
@@ -14,6 +14,7 @@
#include "base/memory/ptr_util.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram_macros.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/syslog_logging.h"
#include "base/threading/thread_task_runner_handle.h"
@@ -174,13 +175,12 @@ GURL ChromeContentVerifierDelegate::GetSignatureFetchUrl(
const base::Version& version) {
// TODO(asargent) Factor out common code from the extension updater's
// ManifestFetchData class that can be shared for use here.
- std::vector<std::string> parts;
- parts.push_back("uc");
- parts.push_back("installsource=signature");
- parts.push_back("id=" + extension_id);
- parts.push_back("v=" + version.GetString());
- std::string x_value =
- net::EscapeQueryParamValue(base::JoinString(parts, "&"), true);
+ std::string id_part = "id=" + extension_id;
+ std::string version_part = "v=" + version.GetString();
+ std::string x_value = net::EscapeQueryParamValue(
+ base::JoinString({"uc", "installsource=signature", id_part, version_part},
+ "&"),
+ true);
std::string query = "response=redirect&x=" + x_value;
GURL base_url = extension_urls::GetWebstoreUpdateUrl();

Powered by Google App Engine
This is Rietveld 408576698