Make SendStatisticsProxy paramter mandatory in ViEEncoder ctor.

Make SendStatisticsProxy paramter mandatory in ViEEncoder ctor.

The only implementation which used a nullptr was a mock used in tests,
so add a dummy instance there instead.
Remove tests for stats_proxy_ in vie_encoder and just dcheck in the
constructor instead.

BUG=None

Review-Url: https://codereview.webrtc.org/2695643002
Cr-Commit-Position: refs/heads/master@{#16577}
Committed: https://chromium.googlesource.com/external/webrtc/+/552c7c70b0d0d0fb50436802eb51eb4e87ee449d

[sprang_webrtc, 2017-02-13 10:11:15]

The CQ bit was checked by sprang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 10:11:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-13 10:40:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 10:40:53]

Dry run: Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/16143)

[sprang_webrtc, 2017-02-13 10:47:57]

The CQ bit was checked by sprang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 10:48:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sprang_webrtc, 2017-02-13 10:59:10]

sprang@webrtc.org changed reviewers:
+ ilnik@webrtc.org

[ilnik, 2017-02-13 11:33:53]

On 2017/02/13 10:59:11, språng wrote:

lgtm

[sprang_webrtc, 2017-02-13 11:35:55]

The CQ bit was checked by sprang@webrtc.org

[commit-bot: I haz the power, 2017-02-13 11:35:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-13 12:41:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486985755240590,
"parent_rev": "14584623035b29ce2a7830ea38956a10c584248d", "commit_rev":
"552c7c70b0d0d0fb50436802eb51eb4e87ee449d"}

[commit-bot: I haz the power, 2017-02-13 12:41:49]

Description was changed from

==========
Make SendStatisticsProxy paramter mandatory in ViEEncoder ctor.

The only implementation which used a nullptr was a mock used in tests,
so add a dummy instance there instead.
Remove tests for stats_proxy_ in vie_encoder and just dcheck in the
constructor instead.

BUG=None
==========

to

==========
Make SendStatisticsProxy paramter mandatory in ViEEncoder ctor.

The only implementation which used a nullptr was a mock used in tests,
so add a dummy instance there instead.
Remove tests for stats_proxy_ in vie_encoder and just dcheck in the
constructor instead.

BUG=None

Review-Url: https://codereview.webrtc.org/2695643002
Cr-Commit-Position: refs/heads/master@{#16577}
Committed:
https://chromium.googlesource.com/external/webrtc/+/552c7c70b0d0d0fb50436802e...
==========

[commit-bot: I haz the power, 2017-02-13 12:41:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/552c7c70b0d0d0fb50436802e...