Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: webrtc/video/encoder_rtcp_feedback_unittest.cc

Issue 2695643002: Make SendStatisticsProxy paramter mandatory in ViEEncoder ctor. (Closed)
Patch Set: oopsie Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/encoder_rtcp_feedback_unittest.cc
diff --git a/webrtc/video/encoder_rtcp_feedback_unittest.cc b/webrtc/video/encoder_rtcp_feedback_unittest.cc
index ca4aa6602a3443886f1d5635c6c84ea6f7ee611a..1ddf4895a6206453c0b96ceca78a5fb6cb3d1aae 100644
--- a/webrtc/video/encoder_rtcp_feedback_unittest.cc
+++ b/webrtc/video/encoder_rtcp_feedback_unittest.cc
@@ -13,6 +13,7 @@
#include "webrtc/modules/utility/include/mock/mock_process_thread.h"
#include "webrtc/test/gmock.h"
#include "webrtc/test/gtest.h"
+#include "webrtc/video/send_statistics_proxy.h"
#include "webrtc/video/vie_encoder.h"
using ::testing::NiceMock;
@@ -21,9 +22,9 @@ namespace webrtc {
class MockVieEncoder : public ViEEncoder {
public:
- MockVieEncoder()
+ explicit MockVieEncoder(SendStatisticsProxy* send_stats_proxy)
: ViEEncoder(1,
- nullptr,
+ send_stats_proxy,
VideoSendStream::Config::EncoderSettings("fake", 0, nullptr),
nullptr,
nullptr) {}
@@ -38,6 +39,10 @@ class VieKeyRequestTest : public ::testing::Test {
public:
VieKeyRequestTest()
: simulated_clock_(123456789),
+ send_stats_proxy_(&simulated_clock_,
+ VideoSendStream::Config(nullptr),
+ VideoEncoderConfig::ContentType::kRealtimeVideo),
+ encoder_(&send_stats_proxy_),
encoder_rtcp_feedback_(
&simulated_clock_,
std::vector<uint32_t>(1, VieKeyRequestTest::kSsrc),
@@ -45,8 +50,10 @@ class VieKeyRequestTest : public ::testing::Test {
protected:
const uint32_t kSsrc = 1234;
- MockVieEncoder encoder_;
+
SimulatedClock simulated_clock_;
+ SendStatisticsProxy send_stats_proxy_;
+ MockVieEncoder encoder_;
EncoderRtcpFeedback encoder_rtcp_feedback_;
};
« no previous file with comments | « no previous file | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698