Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: webrtc/api/BUILD.gn

Issue 2692723002: Adding RTCErrorOr class to be used by ORTC APIs. (Closed)
Patch Set: Changing "CreateAndLogError" to a macro. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/BUILD.gn ('k') | webrtc/api/peerconnectioninterface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/BUILD.gn
diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn
index 2e3d5fe25d3baef9cea4590d66cd8c7aa475591a..39ee06b4f347029284ee3902c82747fded1dab13 100644
--- a/webrtc/api/BUILD.gn
+++ b/webrtc/api/BUILD.gn
@@ -61,6 +61,8 @@ rtc_static_library("libjingle_peerconnection_api") {
"peerconnectioninterface.h",
"peerconnectionproxy.h",
"proxy.h",
+ "rtcerror.cc",
+ "rtcerror.h",
"rtpparameters.h",
"rtpreceiverinterface.h",
"rtpsender.h",
@@ -200,4 +202,29 @@ if (rtc_include_tests) {
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
+
+ rtc_test("rtc_api_unittests") {
kjellander_webrtc 2017/02/21 10:48:03 Can you make this a rtc_source_set and add it as a
kwiberg-webrtc 2017/02/21 12:00:26 I'm neutral on the issue of having more test binar
kjellander_webrtc 2017/02/21 12:01:44 Right, but at least I expect them all to be fast.
Taylor Brandstetter 2017/02/21 17:59:32 Here: https://codereview.webrtc.org/2709573003 It
+ testonly = true
+
+ sources = [
+ "rtcerror_unittest.cc",
+ ]
+
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+
+ deps = [
+ ":libjingle_peerconnection_api",
+ "../base:rtc_base_tests_main",
+ "../base:rtc_base_tests_utils",
+ "../system_wrappers:metrics_default",
+ "../test:test_support",
+ ]
+
+ if (is_android) {
+ deps += [ "//testing/android/native_test:native_test_support" ]
+ }
+ }
}
« no previous file with comments | « webrtc/BUILD.gn ('k') | webrtc/api/peerconnectioninterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698