Adding RTCErrorOr class to be used by ORTC APIs.

webrtc/api/BUILD.gn

 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 if (is_android) {
@@ skipping 43 matching lines @@
     "mediastreamtrack.h",
     "mediastreamtrackproxy.h",
     "mediatypes.cc",
     "mediatypes.h",
     "notifier.h",
     "ortcfactoryinterface.h",
     "peerconnectionfactoryproxy.h",
     "peerconnectioninterface.h",
     "peerconnectionproxy.h",
     "proxy.h",
+    "rtcerror.cc",
+    "rtcerror.h",
     "rtpparameters.h",
     "rtpreceiverinterface.h",
     "rtpsender.h",
     "rtpsenderinterface.h",
     "statstypes.cc",
     "statstypes.h",
     "streamcollection.h",
     "trackmediainfomap.cc",
     "trackmediainfomap.h",
     "udptransportinterface.h",
@@ skipping 119 matching lines @@
     ]
     deps = [
       ":libjingle_peerconnection_api",
       "../base:rtc_base_approved",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
+
+  rtc_test("rtc_api_unittests") {

[kjellander_webrtc, 2017/02/21 10:48:03]

Can you make this a rtc_source_set and add it as a dependency in rtc_unittests
instead?
https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?rcl=0bdacd8a...

I'd prefer not adding another test binary if possible. I don't see webrtc/api
will have that many tests long-term.

[kwiberg-webrtc, 2017/02/21 12:00:26]

I'm neutral on the issue of having more test binaries or not, but webrtc/api/
will probably end up with a bunch of unit tests. Stuff like ArrayView, Optional,
Buffer, checks.h, etc. are going to have to move to api/ sooner or later.

[kjellander_webrtc, 2017/02/21 12:01:44]

Right, but at least I expect them all to be fast. Not stuff like ramping up
bitrates and things like that.
Please let's try to not introduce a new one here.

[Taylor Brandstetter, 2017/02/21 17:59:32]

Here: https://codereview.webrtc.org/2709573003

It was on my to-do list to do something about this anyway, since
rtc_api_unittests isn't being run yet.

+    testonly = true
+
+    sources = [
+      "rtcerror_unittest.cc",
+    ]
+
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+    }
+
+    deps = [
+      ":libjingle_peerconnection_api",
+      "../base:rtc_base_tests_main",
+      "../base:rtc_base_tests_utils",
+      "../system_wrappers:metrics_default",
+      "../test:test_support",
+    ]
+
+    if (is_android) {
+      deps += [ "//testing/android/native_test:native_test_support" ]
+    }
+  }
 }