Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2687573003: Reland of Avoid calling PostTask in audio callbacks (Closed)

Created:
3 years, 10 months ago by henrika_webrtc
Modified:
3 years, 10 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Avoid calling PostTask in audio callbacks (patchset #1 id:1 of https://codereview.webrtc.org/2684913003/ ) Reason for revert: The reason for reverting was false alarm. Original issue's description: > Revert of Avoid calling PostTask in audio callbacks (patchset #6 id:100001 of https://codereview.webrtc.org/2663383004/ ) > > Reason for revert: > Speculative revert to see if this CL caused a change in performance tests. > > See https://bugs.chromium.org/p/chromium/issues/detail?id=689919 for details. > > Original issue's description: > > Avoid calling PostTask in audio callbacks. > > > > We have seen that PostTask can consume some CPU and the way we used it > > before (logging only) in the ADB is not worth the cost we see when > > profiling. > > > > This CL simply moves frequent (trivial) stat updates from the task queue > > to the native threads to avoid calling PostTask in each callback. > > The reason for doing so before was to avoid locks but we can live without > > them since races are benign here. > > > > > > BUG=webrtc:7096 > > > > Review-Url: https://codereview.webrtc.org/2663383004 > > Cr-Commit-Position: refs/heads/master@{#16429} > > Committed: https://chromium.googlesource.com/external/webrtc/+/77ce9a55415a673422d424ed862be142d5e277ef > > TBR=solenberg@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7096 > > Review-Url: https://codereview.webrtc.org/2684913003 > Cr-Commit-Position: refs/heads/master@{#16490} > Committed: https://chromium.googlesource.com/external/webrtc/+/fd8f102a847e7f8bd9c719ec6cc0b5818b626705 TBR=solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7096 Review-Url: https://codereview.webrtc.org/2687573003 Cr-Commit-Position: refs/heads/master@{#16497} Committed: https://chromium.googlesource.com/external/webrtc/+/87d11cdbca721c93cf3856026e1bce02c21abdff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -102 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 6 chunks +49 lines, -38 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 5 chunks +43 lines, -64 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
henrika_webrtc
Created Reland of Avoid calling PostTask in audio callbacks
3 years, 10 months ago (2017-02-08 15:16:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2687573003/1
3 years, 10 months ago (2017-02-08 15:16:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/87d11cdbca721c93cf3856026e1bce02c21abdff
3 years, 10 months ago (2017-02-08 15:17:00 UTC) #6
the sun
3 years, 10 months ago (2017-02-08 15:57:48 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698