Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2684913003: Revert of Avoid calling PostTask in audio callbacks (Closed)

Created:
3 years, 10 months ago by henrika_webrtc
Modified:
3 years, 10 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Avoid calling PostTask in audio callbacks (patchset #6 id:100001 of https://codereview.webrtc.org/2663383004/ ) Reason for revert: Speculative revert to see if this CL caused a change in performance tests. See https://bugs.chromium.org/p/chromium/issues/detail?id=689919 for details. Original issue's description: > Avoid calling PostTask in audio callbacks. > > We have seen that PostTask can consume some CPU and the way we used it > before (logging only) in the ADB is not worth the cost we see when > profiling. > > This CL simply moves frequent (trivial) stat updates from the task queue > to the native threads to avoid calling PostTask in each callback. > The reason for doing so before was to avoid locks but we can live without > them since races are benign here. > > > BUG=webrtc:7096 > > Review-Url: https://codereview.webrtc.org/2663383004 > Cr-Commit-Position: refs/heads/master@{#16429} > Committed: https://chromium.googlesource.com/external/webrtc/+/77ce9a55415a673422d424ed862be142d5e277ef TBR=solenberg@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7096 Review-Url: https://codereview.webrtc.org/2684913003 Cr-Commit-Position: refs/heads/master@{#16490} Committed: https://chromium.googlesource.com/external/webrtc/+/fd8f102a847e7f8bd9c719ec6cc0b5818b626705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -92 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 6 chunks +38 lines, -49 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 5 chunks +64 lines, -43 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
henrika_webrtc
Created Revert of Avoid calling PostTask in audio callbacks
3 years, 10 months ago (2017-02-08 12:30:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2684913003/1
3 years, 10 months ago (2017-02-08 12:30:36 UTC) #3
the sun
Weird.
3 years, 10 months ago (2017-02-08 13:12:21 UTC) #4
the sun
lgtm
3 years, 10 months ago (2017-02-08 13:12:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/fd8f102a847e7f8bd9c719ec6cc0b5818b626705
3 years, 10 months ago (2017-02-08 13:23:19 UTC) #8
henrika_webrtc
3 years, 10 months ago (2017-02-08 15:16:38 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2687573003/ by henrika@webrtc.org.

The reason for reverting is: The reason for reverting was false alarm..

Powered by Google App Engine
This is Rietveld 408576698