Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2685583006: Reland of Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. (Closed)

Created:
3 years, 10 months ago by ilnik
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. (patchset #2 id:150001 of https://codereview.webrtc.org/2687073002/ ) Reason for revert: Reverting was done incorrectly. Returning patchset. Original issue's description: > Revert of Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. (patchset #5 id:80001 of https://codereview.webrtc.org/2668763004/ ) > > Reason for revert: > Speculative revert due to regression in perf tests. > > Original issue's description: > > Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. > > > > > > BUG=webrtc:7095 > > > > Review-Url: https://codereview.webrtc.org/2668763004 > > Cr-Commit-Position: refs/heads/master@{#16428} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5f4712686550ba1d069c5e4c456ffcabe7ccba97 > > TBR=sprang@webrtc.org,nisse@webrtc.org,mflodman@webrtc.org,magjed@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7095 > > Review-Url: https://codereview.webrtc.org/2687073002 > Cr-Commit-Position: refs/heads/master@{#16510} > Committed: https://chromium.googlesource.com/external/webrtc/+/e67c59e7d2fce1fcdb013605f37344a802dfc9e5 TBR=sprang@webrtc.org,nisse@webrtc.org,mflodman@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7095 Review-Url: https://codereview.webrtc.org/2685583006 Cr-Commit-Position: refs/heads/master@{#16512} Committed: https://chromium.googlesource.com/external/webrtc/+/3dd5ad9d50dcda5f027cccb5e672526cbd2ee7c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -27 lines) Patch
M webrtc/common_video/include/frame_callback.h View 1 chunk +22 lines, -3 lines 0 comments Download
M webrtc/video/full_stack_tests.cc View 1 chunk +111 lines, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 12 chunks +40 lines, -21 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
ilnik
Created Reland of Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps.
3 years, 10 months ago (2017-02-09 12:58:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2685583006/1
3 years, 10 months ago (2017-02-09 12:58:47 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 12:58:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3dd5ad9d50dcda5f027cccb5e...

Powered by Google App Engine
This is Rietveld 408576698