Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Issue 2687073002: Revert of Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. (Closed)

Created:
3 years, 10 months ago by ilnik
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. (patchset #5 id:80001 of https://codereview.webrtc.org/2668763004/ ) Reason for revert: Speculative revert due to regression in perf tests. Original issue's description: > Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. > > > BUG=webrtc:7095 > > Review-Url: https://codereview.webrtc.org/2668763004 > Cr-Commit-Position: refs/heads/master@{#16428} > Committed: https://chromium.googlesource.com/external/webrtc/+/5f4712686550ba1d069c5e4c456ffcabe7ccba97 TBR=sprang@webrtc.org,nisse@webrtc.org,mflodman@webrtc.org,magjed@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7095 Review-Url: https://codereview.webrtc.org/2687073002 Cr-Commit-Position: refs/heads/master@{#16510} Committed: https://chromium.googlesource.com/external/webrtc/+/e67c59e7d2fce1fcdb013605f37344a802dfc9e5

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -177 lines) Patch
M webrtc/common_video/include/frame_callback.h View 1 1 chunk +3 lines, -22 lines 0 comments Download
M webrtc/video/full_stack_tests.cc View 1 1 chunk +0 lines, -111 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 12 chunks +21 lines, -40 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ilnik
Created Revert of Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps.
3 years, 10 months ago (2017-02-09 09:20:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2687073002/1
3 years, 10 months ago (2017-02-09 09:20:30 UTC) #3
commit-bot: I haz the power
Failed to apply patch for webrtc/common_video/include/frame_callback.h: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-09 10:19:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2687073002/150001
3 years, 10 months ago (2017-02-09 10:27:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_memcheck on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/5012)
3 years, 10 months ago (2017-02-09 11:32:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2687073002/150001
3 years, 10 months ago (2017-02-09 11:51:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:150001) as https://chromium.googlesource.com/external/webrtc/+/e67c59e7d2fce1fcdb013605f37344a802dfc9e5
3 years, 10 months ago (2017-02-09 12:09:01 UTC) #14
ilnik
3 years, 10 months ago (2017-02-09 12:58:38 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:150001) has been created in
https://codereview.webrtc.org/2685583006/ by ilnik@webrtc.org.

The reason for reverting is: Reverting was done incorrectly. Returning
patchset..

Powered by Google App Engine
This is Rietveld 408576698