Remove unused methods in WebRtcVoiceEngine and VoiceMediaChannel.

Remove unused methods in WebRtcVoiceEngine and VoiceMediaChannel.

These methods relate to typing detection but are not used anymore. Typing detection is enabled through the VoiceDetection module on the APM.

BUG=webrtc:4690
Review-Url: https://codereview.webrtc.org/2684933008
Cr-Commit-Position: refs/heads/master@{#16527}
Committed: https://chromium.googlesource.com/external/webrtc/+/55c5be0a03bf7510fc6acada496551befb181918

[the sun, 2017-02-09 13:26:04]

solenberg@webrtc.org changed reviewers:
+ peah@webrtc.org

[the sun, 2017-02-09 13:27:24]

Description was changed from

==========
Remove unused methods in WebRtcVoiceEngine and VoiceMediaChannel.

BUG=webrtc:4690
==========

to

==========
Remove unused methods in WebRtcVoiceEngine and VoiceMediaChannel.

These methods relate to typing detection but are not used anymore. Typing
detection is enabled through the VoiceDetection module on the APM.

BUG=webrtc:4690
==========

[the sun, 2017-02-09 15:41:06]

solenberg@webrtc.org changed reviewers:
+ ossu@webrtc.org
- peah@webrtc.org

[the sun, 2017-02-09 15:43:35]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 15:43:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ossu, 2017-02-09 15:49:03]

Are we sure these aren't used anywhere?
As long as the FYI bots go green, this lgtm!

https://codereview.webrtc.org/2684933008/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (left):

https://codereview.webrtc.org/2684933008/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:2415: ret *= 1000;  // We return ms,
webrtc returns seconds.
This is the most confusing comment I've seen in a while. I thought this _was_
WebRTC.

[the sun, 2017-02-09 16:08:00]

On 2017/02/09 15:49:03, ossu wrote:
> Are we sure these aren't used anywhere?
> As long as the FYI bots go green, this lgtm!

Bots are green, code is internal. I couldn't find any place where this is
called.

>
https://codereview.webrtc.org/2684933008/diff/20001/webrtc/media/engine/webrt...
> File webrtc/media/engine/webrtcvoiceengine.cc (left):
> 
>
https://codereview.webrtc.org/2684933008/diff/20001/webrtc/media/engine/webrt...
> webrtc/media/engine/webrtcvoiceengine.cc:2415: ret *= 1000;  // We return ms,
> webrtc returns seconds.
> This is the most confusing comment I've seen in a while. I thought this _was_
> WebRTC.

Well, that gives you a hint of how outdated these functions are. :)

[commit-bot: I haz the power, 2017-02-09 17:05:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 17:05:46]

Dry run: This issue passed the CQ dry run.

[the sun, 2017-02-10 09:18:04]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2017-02-10 09:18:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-10 09:20:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486718284013960,
"parent_rev": "654d54c07385cf46f17693906aacb7716a2a3e14", "commit_rev":
"55c5be0a03bf7510fc6acada496551befb181918"}

[commit-bot: I haz the power, 2017-02-10 09:20:28]

Description was changed from

==========
Remove unused methods in WebRtcVoiceEngine and VoiceMediaChannel.

These methods relate to typing detection but are not used anymore. Typing
detection is enabled through the VoiceDetection module on the APM.

BUG=webrtc:4690
==========

to

==========
Remove unused methods in WebRtcVoiceEngine and VoiceMediaChannel.

These methods relate to typing detection but are not used anymore. Typing
detection is enabled through the VoiceDetection module on the APM.

BUG=webrtc:4690

Review-Url: https://codereview.webrtc.org/2684933008
Cr-Commit-Position: refs/heads/master@{#16527}
Committed:
https://chromium.googlesource.com/external/webrtc/+/55c5be0a03bf7510fc6acada4...
==========

[commit-bot: I haz the power, 2017-02-10 09:20:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/55c5be0a03bf7510fc6acada4...