Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2684933008: Remove unused methods in WebRtcVoiceEngine and VoiceMediaChannel. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index b07e9bb5db7339b55666b92a358d1f01913040cb..6c097eae4dbb2ff3c4a4efbd26f5e90f637bba1a 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -2405,31 +2405,6 @@ int WebRtcVoiceMediaChannel::GetOutputLevel() {
return highest;
}
-int WebRtcVoiceMediaChannel::GetTimeSinceLastTyping() {
- int ret;
- if (engine()->voe()->processing()->TimeSinceLastTyping(ret) == -1) {
- // In case of error, log the info and continue
- LOG_RTCERR0(TimeSinceLastTyping);
- ret = -1;
- } else {
- ret *= 1000; // We return ms, webrtc returns seconds.
ossu 2017/02/09 15:49:03 This is the most confusing comment I've seen in a
- }
- return ret;
-}
-
-void WebRtcVoiceMediaChannel::SetTypingDetectionParameters(int time_window,
- int cost_per_typing, int reporting_threshold, int penalty_decay,
- int type_event_delay) {
- if (engine()->voe()->processing()->SetTypingDetectionParameters(
- time_window, cost_per_typing,
- reporting_threshold, penalty_decay, type_event_delay) == -1) {
- // In case of error, log the info and continue
- LOG_RTCERR5(SetTypingDetectionParameters, time_window,
- cost_per_typing, reporting_threshold, penalty_decay,
- type_event_delay);
- }
-}
-
bool WebRtcVoiceMediaChannel::SetOutputVolume(uint32_t ssrc, double volume) {
RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
if (ssrc == 0) {
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698