Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2682253002: Remove PC factory options param from LocalAudioSource::Create. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove PC factory options param from LocalAudioSource::Create. It wasn't being used at all, and there's no need to tie LocalAudioSource to PeerConnection. BUG=None Review-Url: https://codereview.webrtc.org/2682253002 Cr-Commit-Position: refs/heads/master@{#16550} Committed: https://chromium.googlesource.com/external/webrtc/+/757146baf1fa6157ff8d34fc8e8b6c33d6f84a51

Patch Set 1 #

Patch Set 2 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -32 lines) Patch
M webrtc/pc/localaudiosource.h View 3 chunks +2 lines, -7 lines 0 comments Download
M webrtc/pc/localaudiosource.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/pc/localaudiosource_unittest.cc View 7 chunks +8 lines, -15 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/pc/rtpsenderreceiver_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
pthatcher1
lgtm
3 years, 10 months ago (2017-02-10 18:22:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2682253002/20001
3 years, 10 months ago (2017-02-11 04:39:35 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 05:26:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/757146baf1fa6157ff8d34fc8...

Powered by Google App Engine
This is Rietveld 408576698