Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: webrtc/pc/rtpsenderreceiver_unittest.cc

Issue 2682253002: Remove PC factory options param from LocalAudioSource::Create. (Closed)
Patch Set: Rebase onto master Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/peerconnectionfactory.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 // associated and disassociated with a VideoRtpReceiver. 297 // associated and disassociated with a VideoRtpReceiver.
298 TEST_F(RtpSenderReceiverTest, AddAndDestroyVideoRtpReceiver) { 298 TEST_F(RtpSenderReceiverTest, AddAndDestroyVideoRtpReceiver) {
299 CreateVideoRtpReceiver(); 299 CreateVideoRtpReceiver();
300 DestroyVideoRtpReceiver(); 300 DestroyVideoRtpReceiver();
301 } 301 }
302 302
303 // Test that the AudioRtpSender applies options from the local audio source. 303 // Test that the AudioRtpSender applies options from the local audio source.
304 TEST_F(RtpSenderReceiverTest, LocalAudioSourceOptionsApplied) { 304 TEST_F(RtpSenderReceiverTest, LocalAudioSourceOptionsApplied) {
305 cricket::AudioOptions options; 305 cricket::AudioOptions options;
306 options.echo_cancellation = rtc::Optional<bool>(true); 306 options.echo_cancellation = rtc::Optional<bool>(true);
307 auto source = LocalAudioSource::Create( 307 auto source = LocalAudioSource::Create(&options);
308 PeerConnectionFactoryInterface::Options(), &options);
309 CreateAudioRtpSender(source.get()); 308 CreateAudioRtpSender(source.get());
310 309
311 EXPECT_EQ(rtc::Optional<bool>(true), 310 EXPECT_EQ(rtc::Optional<bool>(true),
312 voice_media_channel_->options().echo_cancellation); 311 voice_media_channel_->options().echo_cancellation);
313 312
314 DestroyAudioRtpSender(); 313 DestroyAudioRtpSender();
315 } 314 }
316 315
317 // Test that the stream is muted when the track is disabled, and unmuted when 316 // Test that the stream is muted when the track is disabled, and unmuted when
318 // the track is enabled. 317 // the track is enabled.
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 // Make sure the signal from "GetOnDestroyedSignal()" fires when the sender is 799 // Make sure the signal from "GetOnDestroyedSignal()" fires when the sender is
801 // destroyed, which is needed for the DTMF sender. 800 // destroyed, which is needed for the DTMF sender.
802 TEST_F(RtpSenderReceiverTest, TestOnDestroyedSignal) { 801 TEST_F(RtpSenderReceiverTest, TestOnDestroyedSignal) {
803 CreateAudioRtpSender(); 802 CreateAudioRtpSender();
804 EXPECT_FALSE(audio_sender_destroyed_signal_fired_); 803 EXPECT_FALSE(audio_sender_destroyed_signal_fired_);
805 audio_rtp_sender_ = nullptr; 804 audio_rtp_sender_ = nullptr;
806 EXPECT_TRUE(audio_sender_destroyed_signal_fired_); 805 EXPECT_TRUE(audio_sender_destroyed_signal_fired_);
807 } 806 }
808 807
809 } // namespace webrtc 808 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/pc/peerconnectionfactory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698