Fix bug in BitrateProber where an old probe added at a high bitrate will stay active indefinit…

Fix bug in BitrateProber where an old probe added at a high bitrate will stay active indefinitely if the bandwidth estimate becomes too low to probe at that bitrate.

This is solved by timing out probe clusters after 5 seconds of being initiated.

BUG=webrtc:7043
R=terelius@webrtc.org

Review-Url: https://codereview.webrtc.org/2681733004 .
Cr-Commit-Position: refs/heads/master@{#16495}
Committed: https://chromium.googlesource.com/external/webrtc/+/0e3213a18ceceb325f5b679f6eea7aff12059960

[stefan-webrtc, 2017-02-08 07:59:08]

Description was changed from

==========
Fix bug in ProbeController where an old probe added at a high bitrate will stay
be active indefinitely if the bandwidth estimate becomes too low to probe at
that bitrate.

This is solved by timing out probe clusters after 5 seconds of being initiated.

BUG=webrtc:7043
==========

to

==========
Fix bug in BitrateProber where an old probe added at a high bitrate will stay be
active indefinitely if the bandwidth estimate becomes too low to probe at that
bitrate.

This is solved by timing out probe clusters after 5 seconds of being initiated.

BUG=webrtc:7043
==========

[stefan-webrtc, 2017-02-08 08:17:53]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 08:18:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[stefan-webrtc, 2017-02-08 08:18:12]

Description was changed from

==========
Fix bug in BitrateProber where an old probe added at a high bitrate will stay be
active indefinitely if the bandwidth estimate becomes too low to probe at that
bitrate.

This is solved by timing out probe clusters after 5 seconds of being initiated.

BUG=webrtc:7043
==========

to

==========
Fix bug in BitrateProber where an old probe added at a high bitrate will stay
active indefinitely if the bandwidth estimate becomes too low to probe at that
bitrate.

This is solved by timing out probe clusters after 5 seconds of being initiated.

BUG=webrtc:7043
==========

[commit-bot: I haz the power, 2017-02-08 08:19:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 08:19:34]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17234)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/22497)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21247)

[stefan-webrtc, 2017-02-08 10:43:26]

stefan@webrtc.org changed reviewers:
+ sergeyu@chromium.org, terelius@webrtc.org

[stefan-webrtc, 2017-02-08 10:43:26]

terelius for review

sergeyu as fyi, and of course happy to get comments. :)

[terelius, 2017-02-08 14:09:40]

lgtm

[stefan-webrtc, 2017-02-08 14:10:36]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2017-02-08 14:10:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[stefan-webrtc, 2017-02-08 14:19:08]

Description was changed from

==========
Fix bug in BitrateProber where an old probe added at a high bitrate will stay
active indefinitely if the bandwidth estimate becomes too low to probe at that
bitrate.

This is solved by timing out probe clusters after 5 seconds of being initiated.

BUG=webrtc:7043
==========

to

==========
Fix bug in BitrateProber where an old probe added at a high bitrate will stay
active indefinitely if the bandwidth estimate becomes too low to probe at that
bitrate.

This is solved by timing out probe clusters after 5 seconds of being initiated.

BUG=webrtc:7043
R=terelius@webrtc.org

Review-Url: https://codereview.webrtc.org/2681733004 .
Cr-Commit-Position: refs/heads/master@{#16495}
Committed:
https://chromium.googlesource.com/external/webrtc/+/0e3213a18ceceb325f5b679f6...
==========

[stefan-webrtc, 2017-02-08 14:19:10]

Committed patchset #2 (id:20001) manually as
0e3213a18ceceb325f5b679f6eea7aff12059960 (presubmit successful).