Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: webrtc/modules/pacing/bitrate_prober.h

Issue 2681733004: Fix bug in BitrateProber where an old probe added at a high bitrate will stay active indefinit… (Closed)
Patch Set: Add unittest. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/pacing/bitrate_prober.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/pacing/bitrate_prober.h
diff --git a/webrtc/modules/pacing/bitrate_prober.h b/webrtc/modules/pacing/bitrate_prober.h
index 86379ea9be463bf79947ddba1cea94b8f497067e..875c4c23029f5c07763b74548d8947a94ab7333d 100644
--- a/webrtc/modules/pacing/bitrate_prober.h
+++ b/webrtc/modules/pacing/bitrate_prober.h
@@ -38,7 +38,7 @@ class BitrateProber {
// Create a cluster used to probe for |bitrate_bps| with |num_probes| number
// of probes.
- void CreateProbeCluster(int bitrate_bps);
+ void CreateProbeCluster(int bitrate_bps, int64_t now_ms);
// Returns the number of milliseconds until the next probe should be sent to
// get accurate probing.
@@ -81,13 +81,14 @@ class BitrateProber {
int sent_probes = 0;
int sent_bytes = 0;
+ int64_t time_created_ms = -1;
int64_t time_started_ms = -1;
int retries = 0;
};
// Resets the state of the prober and clears any cluster/timing data tracked.
- void ResetState();
+ void ResetState(int64_t now_ms);
int64_t GetNextProbeTime(const ProbeCluster& cluster);
« no previous file with comments | « no previous file | webrtc/modules/pacing/bitrate_prober.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698