Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2681663005: Reland of Add QP sum stats for received streams. (Closed)

Created:
3 years, 10 months ago by sakal
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add QP sum stats for received streams. (patchset #2 id:300001 of https://codereview.webrtc.org/2680893002/ ) Reason for revert: Fix the problem. Original issue's description: > Revert of Add QP sum stats for received streams. (patchset #10 id:180001 of https://codereview.webrtc.org/2649133005/ ) > > Reason for revert: > Breaks downstream build. > > Original issue's description: > > Add QP sum stats for received streams. > > > > This is not implemented yet in any of the decoders. > > > > BUG=webrtc:6541 > > > > Review-Url: https://codereview.webrtc.org/2649133005 > > Cr-Commit-Position: refs/heads/master@{#16475} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ff0e72fd165facac27f0313aa178648782e63bc4 > > TBR=hta@webrtc.org,hbos@webrtc.org,sprang@webrtc.org,magjed@webrtc.org,stefan@webrtc.org,sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6541 > > Review-Url: https://codereview.webrtc.org/2680893002 . > Cr-Commit-Position: refs/heads/master@{#16480} > Committed: https://chromium.googlesource.com/external/webrtc/+/69fb2cca4d54f3df7ceddcd1c3e9b0ad80fa849b TBR=hta@webrtc.org,hbos@webrtc.org,sprang@webrtc.org,magjed@webrtc.org,stefan@webrtc.org,skvlad@webrtc.org BUG=webrtc:6541 Review-Url: https://codereview.webrtc.org/2681663005 Cr-Commit-Position: refs/heads/master@{#16511} Committed: https://chromium.googlesource.com/external/webrtc/+/cc452e117943c558466c34f6ceddada454308342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -37 lines) Patch
M webrtc/media/base/mediachannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/videodecodersoftwarefallbackwrapper_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.h View 1 chunk +7 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 3 chunks +16 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/test/test_util.h View 2 chunks +5 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/test/test_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/statscollector.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/pc/statscollector_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 chunk +16 lines, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 chunk +34 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video/video_stream_decoder.cc View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/video_decoder.h View 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/video_receive_stream.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
sakal
Created Reland of Add QP sum stats for received streams.
3 years, 10 months ago (2017-02-08 08:28:25 UTC) #1
hbos
lgtm
3 years, 10 months ago (2017-02-08 09:29:17 UTC) #2
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-08 11:46:27 UTC) #3
sprang_webrtc
lgtm
3 years, 10 months ago (2017-02-09 11:28:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2681663005/1
3 years, 10 months ago (2017-02-09 12:50:48 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 12:53:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cc452e117943c558466c34f6c...

Powered by Google App Engine
This is Rietveld 408576698