Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 2680893002: Revert of Add QP sum stats for received streams. (Closed)

Created:
3 years, 10 months ago by skvlad
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add QP sum stats for received streams. (patchset #10 id:180001 of https://codereview.webrtc.org/2649133005/ ) Reason for revert: Breaks downstream build. Original issue's description: > Add QP sum stats for received streams. > > This is not implemented yet in any of the decoders. > > BUG=webrtc:6541 > > Review-Url: https://codereview.webrtc.org/2649133005 > Cr-Commit-Position: refs/heads/master@{#16475} > Committed: https://chromium.googlesource.com/external/webrtc/+/ff0e72fd165facac27f0313aa178648782e63bc4 TBR=hta@webrtc.org,hbos@webrtc.org,sprang@webrtc.org,magjed@webrtc.org,stefan@webrtc.org,sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6541 Review-Url: https://codereview.webrtc.org/2680893002 . Cr-Commit-Position: refs/heads/master@{#16480} Committed: https://chromium.googlesource.com/external/webrtc/+/69fb2cca4d54f3df7ceddcd1c3e9b0ad80fa849b

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -131 lines) Patch
M webrtc/media/base/mediachannel.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/videodecodersoftwarefallbackwrapper_unittest.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.h View 1 1 chunk +5 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 1 3 chunks +6 lines, -15 lines 0 comments Download
M webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/test/test_util.h View 1 2 chunks +12 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/test/test_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/statscollector.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/pc/statscollector_unittest.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 1 chunk +1 line, -16 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 1 chunk +1 line, -34 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/video/video_stream_decoder.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/video_decoder.h View 1 1 chunk +1 line, -8 lines 0 comments Download
M webrtc/video_receive_stream.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
skvlad
Created Revert of Add QP sum stats for received streams.
3 years, 10 months ago (2017-02-07 18:46:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2680893002/1
3 years, 10 months ago (2017-02-07 18:46:11 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-07 18:46:12 UTC) #5
niklas.enbom
On 2017/02/07 18:46:12, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-07 18:48:24 UTC) #6
skvlad
Committed patchset #2 (id:300001) manually as 69fb2cca4d54f3df7ceddcd1c3e9b0ad80fa849b (presubmit successful).
3 years, 10 months ago (2017-02-07 18:59:29 UTC) #9
sakal
3 years, 10 months ago (2017-02-08 08:28:25 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:300001) has been created in
https://codereview.webrtc.org/2681663005/ by sakal@webrtc.org.

The reason for reverting is: Fix the problem..

Powered by Google App Engine
This is Rietveld 408576698