Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2680273002: Adding more comments to every header file in api/ subdirectory. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding more comments to every header file in api/ subdirectory. Many of these interfaces are not intuitive, or are the way they are for complex historical reasons, so it would be nice to document these things for future developers. Also, many nonstandard things (such as RTCConfiguration options) were not documented at all before this CL. BUG=webrtc:7131 TBR=pthatcher@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2680273002 Cr-Commit-Position: refs/heads/master@{#16485} Committed: https://chromium.googlesource.com/external/webrtc/+/b10f32f9b24a7c0e3971b150d2d835c41e685c95

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -181 lines) Patch
M webrtc/api/datachannelinterface.h View 5 chunks +67 lines, -29 lines 0 comments Download
M webrtc/api/dtmfsenderinterface.h View 3 chunks +21 lines, -11 lines 0 comments Download
M webrtc/api/jsep.h View 6 chunks +51 lines, -24 lines 0 comments Download
M webrtc/api/jsepicecandidate.h View 5 chunks +8 lines, -4 lines 0 comments Download
M webrtc/api/jsepsessiondescription.h View 3 chunks +7 lines, -3 lines 0 comments Download
M webrtc/api/mediaconstraintsinterface.h View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/api/mediastreaminterface.h View 11 chunks +43 lines, -22 lines 0 comments Download
M webrtc/api/mediastreamproxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/mediastreamtrackproxy.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/notifier.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/peerconnectionfactoryproxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 18 chunks +272 lines, -81 lines 0 comments Download
M webrtc/api/peerconnectionproxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/rtpreceiverinterface.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/rtpsenderinterface.h View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/api/udptransportinterface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/videosourceproxy.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Taylor Brandstetter
3 years, 10 months ago (2017-02-08 08:58:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2680273002/1
3 years, 10 months ago (2017-02-08 08:59:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17239) ios_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 10 months ago (2017-02-08 09:02:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2680273002/40001
3 years, 10 months ago (2017-02-08 09:35:43 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 09:38:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/b10f32f9b24a7c0e3971b150d...

Powered by Google App Engine
This is Rietveld 408576698