Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: webrtc/api/peerconnectionfactoryproxy.h

Issue 2680273002: Adding more comments to every header file in api/ subdirectory. (Closed)
Patch Set: Merge with master Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/notifier.h ('k') | webrtc/api/peerconnectioninterface.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_API_PEERCONNECTIONFACTORYPROXY_H_ 11 #ifndef WEBRTC_API_PEERCONNECTIONFACTORYPROXY_H_
12 #define WEBRTC_API_PEERCONNECTIONFACTORYPROXY_H_ 12 #define WEBRTC_API_PEERCONNECTIONFACTORYPROXY_H_
13 13
14 #include <memory> 14 #include <memory>
15 #include <string> 15 #include <string>
16 #include <utility> 16 #include <utility>
17 17
18 #include "webrtc/api/peerconnectioninterface.h" 18 #include "webrtc/api/peerconnectioninterface.h"
19 #include "webrtc/api/proxy.h" 19 #include "webrtc/api/proxy.h"
20 #include "webrtc/base/bind.h" 20 #include "webrtc/base/bind.h"
21 21
22 namespace webrtc { 22 namespace webrtc {
23 23
24 // TODO(deadbeef): Move this to .cc file and out of api/. What threads methods
25 // are called on is an implementation detail.
24 BEGIN_SIGNALING_PROXY_MAP(PeerConnectionFactory) 26 BEGIN_SIGNALING_PROXY_MAP(PeerConnectionFactory)
25 PROXY_SIGNALING_THREAD_DESTRUCTOR() 27 PROXY_SIGNALING_THREAD_DESTRUCTOR()
26 PROXY_METHOD1(void, SetOptions, const Options&) 28 PROXY_METHOD1(void, SetOptions, const Options&)
27 PROXY_METHOD5(rtc::scoped_refptr<PeerConnectionInterface>, 29 PROXY_METHOD5(rtc::scoped_refptr<PeerConnectionInterface>,
28 CreatePeerConnection, 30 CreatePeerConnection,
29 const PeerConnectionInterface::RTCConfiguration&, 31 const PeerConnectionInterface::RTCConfiguration&,
30 const MediaConstraintsInterface*, 32 const MediaConstraintsInterface*,
31 std::unique_ptr<cricket::PortAllocator>, 33 std::unique_ptr<cricket::PortAllocator>,
32 std::unique_ptr<rtc::RTCCertificateGeneratorInterface>, 34 std::unique_ptr<rtc::RTCCertificateGeneratorInterface>,
33 PeerConnectionObserver*); 35 PeerConnectionObserver*);
(...skipping 28 matching lines...) Expand all
62 // TODO(ivoc): Remove the StartRtcEventLog and StopRtcEventLog functions as 64 // TODO(ivoc): Remove the StartRtcEventLog and StopRtcEventLog functions as
63 // soon as they are removed from PeerConnectionFactoryInterface. 65 // soon as they are removed from PeerConnectionFactoryInterface.
64 PROXY_METHOD1(bool, StartRtcEventLog, rtc::PlatformFile) 66 PROXY_METHOD1(bool, StartRtcEventLog, rtc::PlatformFile)
65 PROXY_METHOD2(bool, StartRtcEventLog, rtc::PlatformFile, int64_t) 67 PROXY_METHOD2(bool, StartRtcEventLog, rtc::PlatformFile, int64_t)
66 PROXY_METHOD0(void, StopRtcEventLog) 68 PROXY_METHOD0(void, StopRtcEventLog)
67 END_PROXY_MAP() 69 END_PROXY_MAP()
68 70
69 } // namespace webrtc 71 } // namespace webrtc
70 72
71 #endif // WEBRTC_API_PEERCONNECTIONFACTORYPROXY_H_ 73 #endif // WEBRTC_API_PEERCONNECTIONFACTORYPROXY_H_
OLDNEW
« no previous file with comments | « webrtc/api/notifier.h ('k') | webrtc/api/peerconnectioninterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698