Allow changing the minimal ICE ping timeout with PeerConnection.SetConfiguration.

Allow changing the minimal ICE ping timeout with PeerConnection.SetConfiguration.

The original CL (https://codereview.webrtc.org/2670053002) only allows it to be set at PeerConnection creation time.

BUG=webrtc:7082
Review-Url: https://codereview.webrtc.org/2677503004
Cr-Commit-Position: refs/heads/master@{#16436}
Committed: https://chromium.googlesource.com/external/webrtc/+/d1f5fdac5c24204bb90594b81492c33d4acfcc62

[skvlad, 2017-02-03 04:06:37]

The CQ bit was checked by skvlad@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 04:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[skvlad, 2017-02-03 04:07:03]

skvlad@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[commit-bot: I haz the power, 2017-02-03 05:11:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 05:11:13]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-02-03 16:41:53]

Could you add a test? (See the "SetConfigurationChangesX" tests in
peerconnectioninterface_unittest.cc)

[skvlad, 2017-02-03 20:42:52]

The CQ bit was checked by skvlad@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 20:43:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[pthatcher2, 2017-02-03 21:27:39]

pthatcher@chromium.org changed reviewers:
+ pthatcher@chromium.org

[pthatcher2, 2017-02-03 21:27:40]

lgtm

[commit-bot: I haz the power, 2017-02-03 21:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 21:36:58]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-02-03 23:56:17]

lgtm

https://codereview.webrtc.org/2677503004/diff/20001/webrtc/pc/peerconnectioni...
File webrtc/pc/peerconnectioninterface_unittest.cc (right):

https://codereview.webrtc.org/2677503004/diff/20001/webrtc/pc/peerconnectioni...
webrtc/pc/peerconnectioninterface_unittest.cc:2235:
EXPECT_TRUE(new_config.ice_check_min_interval);
nit: ASSERT_TRUE, since the next line will crash if the assertion is false

[skvlad, 2017-02-04 00:01:52]

https://codereview.webrtc.org/2677503004/diff/20001/webrtc/pc/peerconnectioni...
File webrtc/pc/peerconnectioninterface_unittest.cc (right):

https://codereview.webrtc.org/2677503004/diff/20001/webrtc/pc/peerconnectioni...
webrtc/pc/peerconnectioninterface_unittest.cc:2235:
EXPECT_TRUE(new_config.ice_check_min_interval);
On 2017/02/03 23:56:17, Taylor Brandstetter wrote:
> nit: ASSERT_TRUE, since the next line will crash if the assertion is false

I'm now comparing it with rtc::Optional<int>(100). Both shorter and safer.

[skvlad, 2017-02-04 00:01:58]

The CQ bit was checked by skvlad@webrtc.org

[skvlad, 2017-02-04 00:01:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
pthatcher@chromium.org, deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2677503004/#ps40001 (title:
"Change the assertion")

[commit-bot: I haz the power, 2017-02-04 00:02:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-04 00:54:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486166518156730,
"parent_rev": "98c437458af3c8270de87dd444b7e0d9856e6ea0", "commit_rev":
"d1f5fdac5c24204bb90594b81492c33d4acfcc62"}

[commit-bot: I haz the power, 2017-02-04 00:54:09]

Description was changed from

==========
Allow changing the minimal ICE ping timeout with
PeerConnection.SetConfiguration.

The original CL (https://codereview.webrtc.org/2670053002) only allows it to be
set at PeerConnection creation time.

BUG=webrtc:7082
==========

to

==========
Allow changing the minimal ICE ping timeout with
PeerConnection.SetConfiguration.

The original CL (https://codereview.webrtc.org/2670053002) only allows it to be
set at PeerConnection creation time.

BUG=webrtc:7082

Review-Url: https://codereview.webrtc.org/2677503004
Cr-Commit-Position: refs/heads/master@{#16436}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d1f5fdac5c24204bb90594b81...
==========

[commit-bot: I haz the power, 2017-02-04 00:54:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/d1f5fdac5c24204bb90594b81...