Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: webrtc/pc/peerconnectioninterface_unittest.cc

Issue 2677503004: Allow changing the minimal ICE ping timeout with PeerConnection.SetConfiguration. (Closed)
Patch Set: Change the assertion Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/peerconnection.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/peerconnectioninterface_unittest.cc
diff --git a/webrtc/pc/peerconnectioninterface_unittest.cc b/webrtc/pc/peerconnectioninterface_unittest.cc
index c2e6e186e459c67338fc783b5c760bf24b5a1671..90f48549902535e63904b8de80c94f945e0e247b 100644
--- a/webrtc/pc/peerconnectioninterface_unittest.cc
+++ b/webrtc/pc/peerconnectioninterface_unittest.cc
@@ -2221,6 +2221,20 @@ TEST_F(PeerConnectionInterfaceTest, SetConfigurationChangesPruneTurnPortsFlag) {
EXPECT_TRUE(port_allocator_->prune_turn_ports());
}
+// Test that the ice check interval can be changed. This does not verify that
+// the setting makes it all the way to P2PTransportChannel, as that would
+// require a very complex set of mocks.
+TEST_F(PeerConnectionInterfaceTest, SetConfigurationChangesIceCheckInterval) {
+ PeerConnectionInterface::RTCConfiguration config;
+ config.ice_check_min_interval = rtc::Optional<int>();
+ CreatePeerConnection(config, nullptr);
+ config.ice_check_min_interval = rtc::Optional<int>(100);
+ EXPECT_TRUE(pc_->SetConfiguration(config));
+ PeerConnectionInterface::RTCConfiguration new_config =
+ pc_->GetConfiguration();
+ EXPECT_EQ(new_config.ice_check_min_interval, rtc::Optional<int>(100));
+}
+
// Test that when SetConfiguration changes both the pool size and other
// attributes, the pooled session is created with the updated attributes.
TEST_F(PeerConnectionInterfaceTest,
« no previous file with comments | « webrtc/pc/peerconnection.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698