Reland of Drop frames until specified bitrate is achieved.

Reland of Drop frames until specified bitrate is achieved. (patchset #1 id:1 of https://codereview.webrtc.org/2666303002/ )

Reason for revert:
Perf test broke as it made assumptions that quality scaling was turned off. This turns out not to be the case. Fixed by turning quality scaling off for the tests.

Original issue's description:
> Revert of Drop frames until specified bitrate is achieved. (patchset #12 id:240001 of https://codereview.webrtc.org/2630333002/ )
> 
> Reason for revert:
> due to failures on perf tests (not on perf stats, but fails running due to dcheck failures), see e.g., https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20(K%20Nexus5)
> 
> Original issue's description:
> > Drop frames until specified bitrate is achieved.
> > 
> > This CL fixes a regression introduced with the new quality scaler
> > where the video would no longer start in a scaled mode. This CL adds
> > code that compares incoming captured frames to the target bitrate,
> > and if they are found to be too large, they are dropped and sinkWants
> > set to a lower resolution. The number of dropped frames should be low
> > (0-4 in most cases) and should not introduce a noticeable delay, or
> > at least should be preferrable to having the first 2-4 seconds of video
> > have very low quality.
> > 
> > BUG=webrtc:6953
> > 
> > Review-Url: https://codereview.webrtc.org/2630333002
> > Cr-Commit-Position: refs/heads/master@{#16391}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/83399caec5762d2dad038b8e9d86163e92c18c9f
> 
> TBR=perkj@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6953
> 
> Review-Url: https://codereview.webrtc.org/2666303002
> Cr-Commit-Position: refs/heads/master@{#16395}
> Committed: https://chromium.googlesource.com/external/webrtc/+/35fc2aa82fb5a562f3f76f2b91a55f05ebfd4874

TBR=perkj@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,minyue@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6953
Review-Url: https://codereview.webrtc.org/2675223002
Cr-Commit-Position: refs/heads/master@{#16473}
Committed: https://chromium.googlesource.com/external/webrtc/+/2bc6864278d74e88711f62b4a735d6e7af4dc4dd

[kthelgason, 2017-02-06 08:48:12]

Created Reland of Drop frames until specified bitrate is achieved.

[minyue-webrtc, 2017-02-06 09:06:42]

On 2017/02/06 08:48:12, kthelgason wrote:
> Created Reland of Drop frames until specified bitrate is achieved.

I have no good judgement here. What I can say is as long as it was the same
implementation as before but with test fixed, it lgtm. A suggestion is put the
original CL in patch set 1 and use patch set 2 to highlight the fix.

[kthelgason, 2017-02-07 10:30:29]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 10:30:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2017-02-07 10:30:52]

stefan, sprang: PTAL.

[commit-bot: I haz the power, 2017-02-07 10:33:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 10:33:31]

Dry run: Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)

[kthelgason, 2017-02-07 10:50:43]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 10:50:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 11:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 11:53:02]

Dry run: This issue passed the CQ dry run.

[sprang_webrtc, 2017-02-07 12:11:09]

lgtm

[kthelgason, 2017-02-07 14:59:53]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2017-02-07 14:59:54]

The patchset sent to the CQ was uploaded after l-g-t-m from minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2675223002/#ps190001 (title:
"remove debug prints")

[commit-bot: I haz the power, 2017-02-07 15:00:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 15:02:23]

CQ is committing da patch.

Bot data: {"patchset_id": 190001, "attempt_start_ts": 1486479593676340,
"parent_rev": "338f78ac95addee5f3540407037d745e7ceca827", "commit_rev":
"2bc6864278d74e88711f62b4a735d6e7af4dc4dd"}

[commit-bot: I haz the power, 2017-02-07 15:02:26]

Description was changed from

==========
Reland of Drop frames until specified bitrate is achieved. (patchset #1 id:1 of
https://codereview.webrtc.org/2666303002/ )

Reason for revert:
Perf test broke as it made assumptions that quality scaling was turned off. This
turns out not to be the case. Fixed by turning quality scaling off for the
tests.

Original issue's description:
> Revert of Drop frames until specified bitrate is achieved. (patchset #12
id:240001 of https://codereview.webrtc.org/2630333002/ )
> 
> Reason for revert:
> due to failures on perf tests (not on perf stats, but fails running due to
dcheck failures), see e.g.,
https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20...
> 
> Original issue's description:
> > Drop frames until specified bitrate is achieved.
> > 
> > This CL fixes a regression introduced with the new quality scaler
> > where the video would no longer start in a scaled mode. This CL adds
> > code that compares incoming captured frames to the target bitrate,
> > and if they are found to be too large, they are dropped and sinkWants
> > set to a lower resolution. The number of dropped frames should be low
> > (0-4 in most cases) and should not introduce a noticeable delay, or
> > at least should be preferrable to having the first 2-4 seconds of video
> > have very low quality.
> > 
> > BUG=webrtc:6953
> > 
> > Review-Url: https://codereview.webrtc.org/2630333002
> > Cr-Commit-Position: refs/heads/master@{#16391}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/83399caec5762d2dad038b8e9...
> 
> TBR=perkj@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6953
> 
> Review-Url: https://codereview.webrtc.org/2666303002
> Cr-Commit-Position: refs/heads/master@{#16395}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/35fc2aa82fb5a562f3f76f2b9...

TBR=perkj@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,minyue@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6953
==========

to

==========
Reland of Drop frames until specified bitrate is achieved. (patchset #1 id:1 of
https://codereview.webrtc.org/2666303002/ )

Reason for revert:
Perf test broke as it made assumptions that quality scaling was turned off. This
turns out not to be the case. Fixed by turning quality scaling off for the
tests.

Original issue's description:
> Revert of Drop frames until specified bitrate is achieved. (patchset #12
id:240001 of https://codereview.webrtc.org/2630333002/ )
> 
> Reason for revert:
> due to failures on perf tests (not on perf stats, but fails running due to
dcheck failures), see e.g.,
https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20...
> 
> Original issue's description:
> > Drop frames until specified bitrate is achieved.
> > 
> > This CL fixes a regression introduced with the new quality scaler
> > where the video would no longer start in a scaled mode. This CL adds
> > code that compares incoming captured frames to the target bitrate,
> > and if they are found to be too large, they are dropped and sinkWants
> > set to a lower resolution. The number of dropped frames should be low
> > (0-4 in most cases) and should not introduce a noticeable delay, or
> > at least should be preferrable to having the first 2-4 seconds of video
> > have very low quality.
> > 
> > BUG=webrtc:6953
> > 
> > Review-Url: https://codereview.webrtc.org/2630333002
> > Cr-Commit-Position: refs/heads/master@{#16391}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/83399caec5762d2dad038b8e9...
> 
> TBR=perkj@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6953
> 
> Review-Url: https://codereview.webrtc.org/2666303002
> Cr-Commit-Position: refs/heads/master@{#16395}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/35fc2aa82fb5a562f3f76f2b9...

TBR=perkj@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,minyue@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6953

Review-Url: https://codereview.webrtc.org/2675223002
Cr-Commit-Position: refs/heads/master@{#16473}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2bc6864278d74e88711f62b4a...
==========

[commit-bot: I haz the power, 2017-02-07 15:02:28]

Committed patchset #4 (id:190001) as
https://chromium.googlesource.com/external/webrtc/+/2bc6864278d74e88711f62b4a...