Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2666303002: Revert of Drop frames until specified bitrate is achieved. (Closed)

Created:
3 years, 10 months ago by minyue-webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman, magjed_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Drop frames until specified bitrate is achieved. (patchset #12 id:240001 of https://codereview.webrtc.org/2630333002/ ) Reason for revert: due to failures on perf tests (not on perf stats, but fails running due to dcheck failures), see e.g., https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20(K%20Nexus5) Original issue's description: > Drop frames until specified bitrate is achieved. > > This CL fixes a regression introduced with the new quality scaler > where the video would no longer start in a scaled mode. This CL adds > code that compares incoming captured frames to the target bitrate, > and if they are found to be too large, they are dropped and sinkWants > set to a lower resolution. The number of dropped frames should be low > (0-4 in most cases) and should not introduce a noticeable delay, or > at least should be preferrable to having the first 2-4 seconds of video > have very low quality. > > BUG=webrtc:6953 > > Review-Url: https://codereview.webrtc.org/2630333002 > Cr-Commit-Position: refs/heads/master@{#16391} > Committed: https://chromium.googlesource.com/external/webrtc/+/83399caec5762d2dad038b8e9d86163e92c18c9f TBR=perkj@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6953 Review-Url: https://codereview.webrtc.org/2666303002 Cr-Commit-Position: refs/heads/master@{#16395} Committed: https://chromium.googlesource.com/external/webrtc/+/35fc2aa82fb5a562f3f76f2b91a55f05ebfd4874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -152 lines) Patch
M webrtc/api/video/video_frame.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/api/video/video_frame.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 15 chunks +17 lines, -24 lines 0 comments Download
M webrtc/modules/video_coding/utility/default_video_bitrate_allocator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 7 chunks +5 lines, -37 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 10 chunks +9 lines, -81 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
minyue-webrtc
Created Revert of Drop frames until specified bitrate is achieved.
3 years, 10 months ago (2017-02-01 11:13:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2666303002/1
3 years, 10 months ago (2017-02-01 11:13:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/35fc2aa82fb5a562f3f76f2b91a55f05ebfd4874
3 years, 10 months ago (2017-02-01 11:14:05 UTC) #6
kthelgason
3 years, 10 months ago (2017-02-06 08:48:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2675223002/ by kthelgason@webrtc.org.

The reason for reverting is: Perf test broke as it made assumptions that quality
scaling was turned off. This turns out not to be the case. Fixed by turning
quality scaling off for the tests..

Powered by Google App Engine
This is Rietveld 408576698