Modify TransportFeedbackPacketLossTrackerTest to use parameterization

Modify TransportFeedbackPacketLossTrackerTest to use parameterization

BUG=webrtc:7058
Review-Url: https://codereview.webrtc.org/2674733002
Cr-Commit-Position: refs/heads/master@{#17019}
Committed: https://chromium.googlesource.com/external/webrtc/+/02455b27a278370368ea44154dba5c1504d4f1d5

[elad.alon_webrtc.org, 2017-02-02 17:39:45]

Description was changed from

==========
Modify TransportFeedbackPacketLossTrackerTest to use parameterization

BUG=
==========

to

==========
Modify TransportFeedbackPacketLossTrackerTest to use parameterization

BUG=webrtc:7058
==========

[elad.alon_webrtc.org, 2017-02-02 17:39:46]

elad.alon@webrtc.org changed reviewers:
+ michaelt@webrtc.org, minyue@webrtc.org, sprang@webrtc.org, stefan@webrtc.org

[elad.alon_webrtc.org, 2017-02-02 17:39:58]

Please have a look.

[stefan-webrtc, 2017-02-03 08:57:29]

lgtm % nit

https://codereview.webrtc.org/2674733002/diff/20001/webrtc/voice_engine/trans...
File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc
(right):

https://codereview.webrtc.org/2674733002/diff/20001/webrtc/voice_engine/trans...
webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:555:
testing::ValuesIn(kBases));
No point in using the constant kBases if it's only used in one place. At least
move it to here so that it's close to where it's being used.

[elad.alon_webrtc.org, 2017-02-07 12:41:22]

Ping?

[michaelt, 2017-02-07 12:44:24]

lgtm

[minyue-webrtc, 2017-02-14 21:23:01]

good work! some small comments / and you need to wait for rebasing.

https://codereview.webrtc.org/2674733002/diff/40001/webrtc/voice_engine/trans...
File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc
(left):

https://codereview.webrtc.org/2674733002/diff/40001/webrtc/voice_engine/trans...
webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:24: using
testing::StrictMock;
nice you found these

https://codereview.webrtc.org/2674733002/diff/40001/webrtc/voice_engine/trans...
File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc
(right):

https://codereview.webrtc.org/2674733002/diff/40001/webrtc/voice_engine/trans...
webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:31:
TransportFeedbackPacketLossTrackerTest() = default;
I think parameter parsing can be placed here. Otherwise, this class becomes too
empty

Specifically,

put base_ as a private number and parse it in ctor

[sprang_webrtc, 2017-02-15 10:47:45]

lgtm

https://codereview.webrtc.org/2674733002/diff/40001/webrtc/voice_engine/trans...
File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc
(right):

https://codereview.webrtc.org/2674733002/diff/40001/webrtc/voice_engine/trans...
webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:31:
TransportFeedbackPacketLossTrackerTest() = default;
On 2017/02/14 21:23:00, minyue-webrtc wrote:
> I think parameter parsing can be placed here. Otherwise, this class becomes
too
> empty
> 
> Specifically,
> 
> put base_ as a private number and parse it in ctor

+1

[elad.alon_webrtc.org, 2017-02-15 17:15:15]

https://codereview.webrtc.org/2674733002/diff/40001/webrtc/voice_engine/trans...
File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc
(right):

https://codereview.webrtc.org/2674733002/diff/40001/webrtc/voice_engine/trans...
webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:31:
TransportFeedbackPacketLossTrackerTest() = default;
On 2017/02/14 21:23:00, minyue-webrtc wrote:
> I think parameter parsing can be placed here. Otherwise, this class becomes
too
> empty
> 
> Specifically,
> 
> put base_ as a private number and parse it in ctor

Done.

[elad.alon_webrtc.org, 2017-03-03 18:53:03]

The CQ bit was checked by elad.alon@webrtc.org

[elad.alon_webrtc.org, 2017-03-03 18:53:03]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org,
sprang@webrtc.org, michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2674733002/#ps160001 (title:
"Rebased")

[commit-bot: I haz the power, 2017-03-03 18:53:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 19:11:07]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1488567183557700,
"parent_rev": "7af935758037dc483581ea701624cdb1a4dc77af", "commit_rev":
"02455b27a278370368ea44154dba5c1504d4f1d5"}

[commit-bot: I haz the power, 2017-03-03 19:11:09]

Description was changed from

==========
Modify TransportFeedbackPacketLossTrackerTest to use parameterization

BUG=webrtc:7058
==========

to

==========
Modify TransportFeedbackPacketLossTrackerTest to use parameterization

BUG=webrtc:7058

Review-Url: https://codereview.webrtc.org/2674733002
Cr-Commit-Position: refs/heads/master@{#17019}
Committed:
https://chromium.googlesource.com/external/webrtc/+/02455b27a278370368ea44154...
==========

[commit-bot: I haz the power, 2017-03-03 19:11:10]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/02455b27a278370368ea44154...