Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc

Issue 2674733002: Modify TransportFeedbackPacketLossTrackerTest to use parameterization (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <limits> 11 #include <limits>
12 #include <memory> 12 #include <memory>
13 #include <numeric> 13 #include <numeric>
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/base/checks.h" 16 #include "webrtc/base/checks.h"
17 #include "webrtc/base/mod_ops.h" 17 #include "webrtc/base/mod_ops.h"
18 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h" 18 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
19 #include "webrtc/test/gmock.h" 19 #include "webrtc/test/gmock.h"
20 #include "webrtc/test/gtest.h" 20 #include "webrtc/test/gtest.h"
21 #include "webrtc/voice_engine/transport_feedback_packet_loss_tracker.h" 21 #include "webrtc/voice_engine/transport_feedback_packet_loss_tracker.h"
22 22
23 using webrtc::rtcp::TransportFeedback; 23 using webrtc::rtcp::TransportFeedback;
24 using testing::Return;
25 using testing::StrictMock;
26 24
27 namespace webrtc { 25 namespace webrtc {
28 26
29 namespace { 27 namespace {
30 28
31 // All tests are run multiple times with various baseline sequence number, 29 class TransportFeedbackPacketLossTrackerTest
32 // to weed out potential bugs with wrap-around handling. 30 : public ::testing::TestWithParam<uint16_t> {
33 constexpr uint16_t kBases[] = {0x0000, 0x3456, 0xc032, 0xfffe}; 31 public:
32 TransportFeedbackPacketLossTrackerTest() = default;
33 virtual ~TransportFeedbackPacketLossTrackerTest() = default;
34
35 protected:
36 uint16_t base_{GetParam()};
37
38 private:
39 RTC_DISALLOW_COPY_AND_ASSIGN(TransportFeedbackPacketLossTrackerTest);
40 };
34 41
35 void SendPackets(TransportFeedbackPacketLossTracker* tracker, 42 void SendPackets(TransportFeedbackPacketLossTracker* tracker,
36 const std::vector<uint16_t>& seq_nums, 43 const std::vector<uint16_t>& seq_nums,
37 bool validate_all = true) { 44 bool validate_all = true) {
38 for (uint16_t seq_num : seq_nums) { 45 for (uint16_t seq_num : seq_nums) {
39 tracker->OnPacketAdded(seq_num); 46 tracker->OnPacketAdded(seq_num);
40 if (validate_all) { 47 if (validate_all) {
41 tracker->Validate(); 48 tracker->Validate();
42 } 49 }
43 } 50 }
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 TEST(TransportFeedbackPacketLossTrackerTest, EmptyWindow) { 132 TEST(TransportFeedbackPacketLossTrackerTest, EmptyWindow) {
126 TransportFeedbackPacketLossTracker tracker(10, 5, 5); 133 TransportFeedbackPacketLossTracker tracker(10, 5, 5);
127 134
128 // PLR and RPLR reported as unknown before reception of first feedback. 135 // PLR and RPLR reported as unknown before reception of first feedback.
129 ValidatePacketLossStatistics(tracker, 136 ValidatePacketLossStatistics(tracker,
130 rtc::Optional<float>(), 137 rtc::Optional<float>(),
131 rtc::Optional<float>()); 138 rtc::Optional<float>());
132 } 139 }
133 140
134 // A feedback received for an empty window has no effect. 141 // A feedback received for an empty window has no effect.
135 TEST(TransportFeedbackPacketLossTrackerTest, EmptyWindowFeedback) { 142 TEST_P(TransportFeedbackPacketLossTrackerTest, EmptyWindowFeedback) {
136 for (uint16_t base : kBases) { 143 TransportFeedbackPacketLossTracker tracker(3, 3, 2);
137 TransportFeedbackPacketLossTracker tracker(3, 3, 2); 144
138 145 // Feedback doesn't correspond to any packets - ignored.
139 // Feedback doesn't correspond to any packets - ignored. 146 AddTransportFeedbackAndValidate(&tracker, base_, {true, false, true});
140 AddTransportFeedbackAndValidate(&tracker, base, {true, false, true}); 147 ValidatePacketLossStatistics(tracker,
141 ValidatePacketLossStatistics(tracker, 148 rtc::Optional<float>(),
142 rtc::Optional<float>(), 149 rtc::Optional<float>());
143 rtc::Optional<float>()); 150
144 151 // After the packets are transmitted, acking them would have an effect.
145 // After the packets are transmitted, acking them would have an effect. 152 SendPacketRange(&tracker, base_, 3);
146 SendPacketRange(&tracker, base, 3); 153 AddTransportFeedbackAndValidate(&tracker, base_, {true, false, true});
147 AddTransportFeedbackAndValidate(&tracker, base, {true, false, true}); 154 ValidatePacketLossStatistics(tracker, 1.0f / 3.0f, 0.5f);
148 ValidatePacketLossStatistics(tracker, 1.0f / 3.0f, 0.5f);
149 }
150 } 155 }
151 156
152 // Sanity check on partially filled window. 157 // Sanity check on partially filled window.
153 TEST(TransportFeedbackPacketLossTrackerTest, PartiallyFilledWindow) { 158 TEST_P(TransportFeedbackPacketLossTrackerTest, PartiallyFilledWindow) {
154 for (uint16_t base : kBases) { 159 TransportFeedbackPacketLossTracker tracker(10, 5, 4);
155 TransportFeedbackPacketLossTracker tracker(10, 5, 4); 160
156 161 // PLR unknown before minimum window size reached.
157 // PLR unknown before minimum window size reached. 162 // RPLR unknown before minimum pairs reached.
158 // RPLR unknown before minimum pairs reached. 163 // Expected window contents: [] -> [1001].
159 // Expected window contents: [] -> [1001]. 164 SendPacketRange(&tracker, base_, 3);
160 SendPacketRange(&tracker, base, 3); 165 AddTransportFeedbackAndValidate(&tracker, base_, {true, false, false, true});
161 AddTransportFeedbackAndValidate(&tracker, base, {true, false, false, true}); 166 ValidatePacketLossStatistics(tracker,
162 ValidatePacketLossStatistics(tracker, 167 rtc::Optional<float>(),
163 rtc::Optional<float>(), 168 rtc::Optional<float>());
164 rtc::Optional<float>());
165 }
166 } 169 }
167 170
168 // Sanity check on minimum filled window - PLR known, RPLR unknown. 171 // Sanity check on minimum filled window - PLR known, RPLR unknown.
169 TEST(TransportFeedbackPacketLossTrackerTest, PlrMinimumFilledWindow) { 172 TEST_P(TransportFeedbackPacketLossTrackerTest, PlrMinimumFilledWindow) {
170 for (uint16_t base : kBases) { 173 TransportFeedbackPacketLossTracker tracker(10, 5, 5);
171 TransportFeedbackPacketLossTracker tracker(10, 5, 5); 174
172 175 // PLR correctly calculated after minimum window size reached.
173 // PLR correctly calculated after minimum window size reached. 176 // RPLR not necessarily known at that time (not if min-pairs not reached).
174 // RPLR not necessarily known at that time (not if min-pairs not reached). 177 // Expected window contents: [] -> [10011].
175 // Expected window contents: [] -> [10011]. 178 SendPacketRange(&tracker, base_, 5);
176 SendPacketRange(&tracker, base, 5); 179 AddTransportFeedbackAndValidate(&tracker, base_,
177 AddTransportFeedbackAndValidate(&tracker, base, 180 {true, false, false, true, true});
178 {true, false, false, true, true}); 181 ValidatePacketLossStatistics(tracker,
179 ValidatePacketLossStatistics(tracker, 182 rtc::Optional<float>(2.0f / 5.0f),
180 rtc::Optional<float>(2.0f / 5.0f), 183 rtc::Optional<float>());
181 rtc::Optional<float>());
182 }
183 } 184 }
184 185
185 // Sanity check on minimum filled window - PLR unknown, RPLR known. 186 // Sanity check on minimum filled window - PLR unknown, RPLR known.
186 TEST(TransportFeedbackPacketLossTrackerTest, RplrMinimumFilledWindow) { 187 TEST_P(TransportFeedbackPacketLossTrackerTest, RplrMinimumFilledWindow) {
187 for (uint16_t base : kBases) { 188 TransportFeedbackPacketLossTracker tracker(10, 6, 4);
188 TransportFeedbackPacketLossTracker tracker(10, 6, 4); 189
189 190 // RPLR correctly calculated after minimum pairs reached.
190 // RPLR correctly calculated after minimum pairs reached. 191 // PLR not necessarily known at that time (not if min window not reached).
191 // PLR not necessarily known at that time (not if min window not reached). 192 // Expected window contents: [] -> [10011].
192 // Expected window contents: [] -> [10011]. 193 SendPacketRange(&tracker, base_, 5);
193 SendPacketRange(&tracker, base, 5); 194 AddTransportFeedbackAndValidate(&tracker, base_,
194 AddTransportFeedbackAndValidate(&tracker, base, 195 {true, false, false, true, true});
195 {true, false, false, true, true}); 196 ValidatePacketLossStatistics(tracker,
196 ValidatePacketLossStatistics(tracker, 197 rtc::Optional<float>(),
197 rtc::Optional<float>(), 198 rtc::Optional<float>(1.0f / 4.0f));
198 rtc::Optional<float>(1.0f / 4.0f));
199 }
200 } 199 }
201 200
202 // Additional reports update PLR and RPLR. 201 // Additional reports update PLR and RPLR.
203 TEST(TransportFeedbackPacketLossTrackerTest, ExtendWindow) { 202 TEST_P(TransportFeedbackPacketLossTrackerTest, ExtendWindow) {
204 for (uint16_t base : kBases) { 203 TransportFeedbackPacketLossTracker tracker(20, 5, 5);
205 TransportFeedbackPacketLossTracker tracker(20, 5, 5); 204
206 205 SendPacketRange(&tracker, base_, 25);
207 SendPacketRange(&tracker, base, 25); 206
208 207 // Expected window contents: [] -> [10011].
209 // Expected window contents: [] -> [10011]. 208 AddTransportFeedbackAndValidate(&tracker, base_,
210 AddTransportFeedbackAndValidate(&tracker, base, 209 {true, false, false, true, true});
211 {true, false, false, true, true}); 210 ValidatePacketLossStatistics(tracker,
212 ValidatePacketLossStatistics(tracker, 211 rtc::Optional<float>(2.0f / 5.0f),
213 rtc::Optional<float>(2.0f / 5.0f), 212 rtc::Optional<float>());
214 rtc::Optional<float>()); 213
215 214 // Expected window contents: [10011] -> [1001110101].
216 // Expected window contents: [10011] -> [1001110101]. 215 AddTransportFeedbackAndValidate(&tracker, base_ + 5,
217 AddTransportFeedbackAndValidate(&tracker, base + 5, 216 {true, false, true, false, true});
218 {true, false, true, false, true}); 217 ValidatePacketLossStatistics(tracker, 4.0f / 10.0f, 3.0f / 9.0f);
219 ValidatePacketLossStatistics(tracker, 4.0f / 10.0f, 3.0f / 9.0f); 218
220 219 // Expected window contents: [1001110101] -> [1001110101-GAP-10001].
221 // Expected window contents: [1001110101] -> [1001110101-GAP-10001]. 220 AddTransportFeedbackAndValidate(&tracker, base_ + 20,
222 AddTransportFeedbackAndValidate(&tracker, base + 20, 221 {true, false, false, false, true});
223 {true, false, false, false, true}); 222 ValidatePacketLossStatistics(tracker, 7.0f / 15.0f, 4.0f / 13.0f);
224 ValidatePacketLossStatistics(tracker, 7.0f / 15.0f, 4.0f / 13.0f);
225 }
226 } 223 }
227 224
228 // Sanity - all packets correctly received. 225 // Sanity - all packets correctly received.
229 TEST(TransportFeedbackPacketLossTrackerTest, AllReceived) { 226 TEST_P(TransportFeedbackPacketLossTrackerTest, AllReceived) {
230 for (uint16_t base : kBases) { 227 TransportFeedbackPacketLossTracker tracker(10, 5, 4);
231 TransportFeedbackPacketLossTracker tracker(10, 5, 4); 228
232 229 // Expected window contents: [] -> [11111].
233 // Expected window contents: [] -> [11111]. 230 SendPacketRange(&tracker, base_, 5);
234 SendPacketRange(&tracker, base, 5); 231 AddTransportFeedbackAndValidate(&tracker, base_,
235 AddTransportFeedbackAndValidate(&tracker, base, 232 {true, true, true, true, true});
236 {true, true, true, true, true}); 233 ValidatePacketLossStatistics(tracker, 0.0f, 0.0f);
237 ValidatePacketLossStatistics(tracker, 0.0f, 0.0f);
238 }
239 } 234 }
240 235
241 // Sanity - all packets lost. 236 // Sanity - all packets lost.
242 TEST(TransportFeedbackPacketLossTrackerTest, AllLost) { 237 TEST_P(TransportFeedbackPacketLossTrackerTest, AllLost) {
243 for (uint16_t base : kBases) { 238 TransportFeedbackPacketLossTracker tracker(10, 5, 4);
244 TransportFeedbackPacketLossTracker tracker(10, 5, 4); 239
245 240 // Expected window contents: [] -> [00000].
246 // Expected window contents: [] -> [00000]. 241 SendPacketRange(&tracker, base_, 5);
247 SendPacketRange(&tracker, base, 5); 242 // Note: Last acked packet (the received one) does not belong to the stream,
248 // Note: Last acked packet (the received one) does not belong to the stream, 243 // and is only there to make sure the feedback message is legal.
249 // and is only there to make sure the feedback message is legal. 244 AddTransportFeedbackAndValidate(&tracker, base_,
250 AddTransportFeedbackAndValidate(&tracker, base, 245 {false, false, false, false, false, true});
251 {false, false, false, false, false, true}); 246 ValidatePacketLossStatistics(tracker, 1.0f, 0.0f);
252 ValidatePacketLossStatistics(tracker, 1.0f, 0.0f);
253 }
254 } 247 }
255 248
256 // Repeated reports are ignored. 249 // Repeated reports are ignored.
257 TEST(TransportFeedbackPacketLossTrackerTest, ReportRepetition) { 250 TEST_P(TransportFeedbackPacketLossTrackerTest, ReportRepetition) {
258 for (uint16_t base : kBases) { 251 TransportFeedbackPacketLossTracker tracker(10, 5, 4);
259 TransportFeedbackPacketLossTracker tracker(10, 5, 4); 252
260 253 SendPacketRange(&tracker, base_, 5);
261 SendPacketRange(&tracker, base, 5); 254
262 255 // Expected window contents: [] -> [10011].
263 // Expected window contents: [] -> [10011]. 256 AddTransportFeedbackAndValidate(&tracker, base_,
264 AddTransportFeedbackAndValidate(&tracker, base, 257 {true, false, false, true, true});
265 {true, false, false, true, true}); 258 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f);
266 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f); 259
267 260 // Repeat entire previous feedback
268 // Repeat entire previous feedback 261 // Expected window contents: [10011] -> [10011].
269 // Expected window contents: [10011] -> [10011]. 262 AddTransportFeedbackAndValidate(&tracker, base_,
270 AddTransportFeedbackAndValidate(&tracker, base, 263 {true, false, false, true, true});
271 {true, false, false, true, true}); 264 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f);
272 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f);
273 }
274 } 265 }
275 266
276 // Report overlap. 267 // Report overlap.
277 TEST(TransportFeedbackPacketLossTrackerTest, ReportOverlap) { 268 TEST_P(TransportFeedbackPacketLossTrackerTest, ReportOverlap) {
278 for (uint16_t base : kBases) { 269 TransportFeedbackPacketLossTracker tracker(10, 5, 1);
279 TransportFeedbackPacketLossTracker tracker(10, 5, 1); 270
280 271 SendPacketRange(&tracker, base_, 15);
281 SendPacketRange(&tracker, base, 15); 272
282 273 // Expected window contents: [] -> [10011].
283 // Expected window contents: [] -> [10011]. 274 AddTransportFeedbackAndValidate(&tracker, base_,
284 AddTransportFeedbackAndValidate(&tracker, base, 275 {true, false, false, true, true});
285 {true, false, false, true, true}); 276 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f);
286 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f); 277
287 278 // Expected window contents: [10011] -> [1001101].
288 // Expected window contents: [10011] -> [1001101]. 279 AddTransportFeedbackAndValidate(&tracker, base_ + 3,
289 AddTransportFeedbackAndValidate(&tracker, base + 3, 280 {true, true, false, true});
290 {true, true, false, true}); 281 ValidatePacketLossStatistics(tracker, 3.0f / 7.0f, 2.0f / 6.0f);
291 ValidatePacketLossStatistics(tracker, 3.0f / 7.0f, 2.0f / 6.0f);
292 }
293 } 282 }
294 283
295 // Report conflict. 284 // Report conflict.
296 TEST(TransportFeedbackPacketLossTrackerTest, ReportConflict) { 285 TEST_P(TransportFeedbackPacketLossTrackerTest, ReportConflict) {
297 for (uint16_t base : kBases) { 286 TransportFeedbackPacketLossTracker tracker(10, 5, 4);
298 TransportFeedbackPacketLossTracker tracker(10, 5, 4); 287
299 288 SendPacketRange(&tracker, base_, 15);
300 SendPacketRange(&tracker, base, 15); 289
301 290 // Expected window contents: [] -> [01001].
302 // Expected window contents: [] -> [01001]. 291 AddTransportFeedbackAndValidate(&tracker, base_,
303 AddTransportFeedbackAndValidate(&tracker, base, 292 {false, true, false, false, true});
304 {false, true, false, false, true}); 293 ValidatePacketLossStatistics(tracker, 3.0f / 5.0f, 2.0f / 4.0f);
305 ValidatePacketLossStatistics(tracker, 3.0f / 5.0f, 2.0f / 4.0f); 294
306 295 // Expected window contents: [01001] -> [11101].
307 // Expected window contents: [01001] -> [11101]. 296 // While false->true will be applied, true -> false will be ignored.
308 // While false->true will be applied, true -> false will be ignored. 297 AddTransportFeedbackAndValidate(&tracker, base_, {true, false, true});
309 AddTransportFeedbackAndValidate(&tracker, base, {true, false, true}); 298 ValidatePacketLossStatistics(tracker, 1.0f / 5.0f, 1.0f / 4.0f);
310 ValidatePacketLossStatistics(tracker, 1.0f / 5.0f, 1.0f / 4.0f);
311 }
312 } 299 }
313 300
314 // Skipped packets treated as unknown (not lost). 301 // Skipped packets treated as unknown (not lost).
315 TEST(TransportFeedbackPacketLossTrackerTest, SkippedPackets) { 302 TEST_P(TransportFeedbackPacketLossTrackerTest, SkippedPackets) {
316 for (uint16_t base : kBases) { 303 TransportFeedbackPacketLossTracker tracker(10, 5, 1);
317 TransportFeedbackPacketLossTracker tracker(10, 5, 1); 304
318 305 SendPacketRange(&tracker, base_, 200);
319 SendPacketRange(&tracker, base, 200); 306
320 307 // Expected window contents: [] -> [10011].
321 // Expected window contents: [] -> [10011]. 308 AddTransportFeedbackAndValidate(&tracker, base_,
322 AddTransportFeedbackAndValidate(&tracker, base, 309 {true, false, false, true, true});
323 {true, false, false, true, true}); 310 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f);
324 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f); 311
325 312 // Expected window contents: [10011] -> [10011-GAP-101].
326 // Expected window contents: [10011] -> [10011-GAP-101]. 313 AddTransportFeedbackAndValidate(&tracker, base_ + 100, {true, false, true});
327 AddTransportFeedbackAndValidate(&tracker, base + 100, {true, false, true}); 314 ValidatePacketLossStatistics(tracker, 3.0f / 8.0f, 2.0f / 6.0f);
328 ValidatePacketLossStatistics(tracker, 3.0f / 8.0f, 2.0f / 6.0f);
329 }
330 } 315 }
331 316
332 // The window retains information up to the configured max-window-size, but 317 // The window retains information up to the configured max-window-size, but
333 // starts discarding after that. (Sent packets are not counted.) 318 // starts discarding after that. (Sent packets are not counted.)
334 TEST(TransportFeedbackPacketLossTrackerTest, MaxWindowSize) { 319 TEST_P(TransportFeedbackPacketLossTrackerTest, MaxWindowSize) {
335 for (uint16_t base : kBases) { 320 TransportFeedbackPacketLossTracker tracker(10, 10, 1);
336 TransportFeedbackPacketLossTracker tracker(10, 10, 1); 321
337 322 SendPacketRange(&tracker, base_, 200);
338 SendPacketRange(&tracker, base, 200); 323
339 324 // Up to max-window-size retained.
340 // Up to max-window-size retained. 325 // Expected window contents: [] -> [1010100001].
341 // Expected window contents: [] -> [1010100001]. 326 AddTransportFeedbackAndValidate(
342 AddTransportFeedbackAndValidate( 327 &tracker, base_,
343 &tracker, base, 328 {true, false, true, false, true, false, false, false, false, true});
344 {true, false, true, false, true, false, false, false, false, true}); 329 ValidatePacketLossStatistics(tracker, 6.0f / 10.0f, 3.0f / 9.0f);
345 ValidatePacketLossStatistics(tracker, 6.0f / 10.0f, 3.0f / 9.0f); 330
346 331 // After max-window-size, older entries discarded to accommodate newer ones.
347 // After max-window-size, older entries discarded to accommodate newer ones. 332 // Expected window contents: [1010100001] -> [0000110111].
348 // Expected window contents: [1010100001] -> [0000110111]. 333 AddTransportFeedbackAndValidate(&tracker, base_ + 10,
349 AddTransportFeedbackAndValidate(&tracker, base + 10, 334 {true, false, true, true, true});
350 {true, false, true, true, true}); 335 ValidatePacketLossStatistics(tracker, 5.0f / 10.0f, 2.0f / 9.0f);
351 ValidatePacketLossStatistics(tracker, 5.0f / 10.0f, 2.0f / 9.0f);
352 }
353 } 336 }
354 337
355 // Inserting a feedback into the middle of a full window works correctly. 338 // Inserting a feedback into the middle of a full window works correctly.
356 TEST(TransportFeedbackPacketLossTrackerTest, InsertIntoMiddle) { 339 TEST_P(TransportFeedbackPacketLossTrackerTest, InsertIntoMiddle) {
357 for (uint16_t base : kBases) { 340 TransportFeedbackPacketLossTracker tracker(10, 5, 1);
358 TransportFeedbackPacketLossTracker tracker(10, 5, 1); 341
359 342 SendPacketRange(&tracker, base_, 300);
360 SendPacketRange(&tracker, base, 300); 343
361 344 // Expected window contents: [] -> [10101].
362 // Expected window contents: [] -> [10101]. 345 AddTransportFeedbackAndValidate(&tracker, base_,
363 AddTransportFeedbackAndValidate(&tracker, base, 346 {true, false, true, false, true});
364 {true, false, true, false, true}); 347 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 2.0f / 4.0f);
365 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 2.0f / 4.0f); 348
366 349 // Expected window contents: [10101] -> [10101-GAP-10001].
367 // Expected window contents: [10101] -> [10101-GAP-10001]. 350 AddTransportFeedbackAndValidate(&tracker, base_ + 100,
368 AddTransportFeedbackAndValidate(&tracker, base + 100, 351 {true, false, false, false, true});
369 {true, false, false, false, true}); 352 ValidatePacketLossStatistics(tracker, 5.0f / 10.0f, 3.0f / 8.0f);
370 ValidatePacketLossStatistics(tracker, 5.0f / 10.0f, 3.0f / 8.0f); 353
371 354 // Insert into the middle of this full window - it discards the older data.
372 // Insert into the middle of this full window - it discards the older data. 355 // Expected window contents: [10101-GAP-10001] -> [11111-GAP-10001].
373 // Expected window contents: [10101-GAP-10001] -> [11111-GAP-10001]. 356 AddTransportFeedbackAndValidate(&tracker, base_ + 50,
374 AddTransportFeedbackAndValidate(&tracker, base + 50, 357 {true, true, true, true, true});
375 {true, true, true, true, true}); 358 ValidatePacketLossStatistics(tracker, 3.0f / 10.0f, 1.0f / 8.0f);
376 ValidatePacketLossStatistics(tracker, 3.0f / 10.0f, 1.0f / 8.0f);
377 }
378 } 359 }
379 360
380 // Inserting feedback into the middle of a full window works correctly - can 361 // Inserting feedback into the middle of a full window works correctly - can
381 // complete two pairs. 362 // complete two pairs.
382 TEST(TransportFeedbackPacketLossTrackerTest, InsertionCompletesTwoPairs) { 363 TEST_P(TransportFeedbackPacketLossTrackerTest, InsertionCompletesTwoPairs) {
383 for (uint16_t base : kBases) { 364 TransportFeedbackPacketLossTracker tracker(15, 5, 1);
384 TransportFeedbackPacketLossTracker tracker(15, 5, 1); 365
385 366 SendPacketRange(&tracker, base_, 300);
386 SendPacketRange(&tracker, base, 300); 367
387 368 // Expected window contents: [] -> [10111].
388 // Expected window contents: [] -> [10111]. 369 AddTransportFeedbackAndValidate(&tracker, base_,
389 AddTransportFeedbackAndValidate(&tracker, base, 370 {true, false, true, true, true});
390 {true, false, true, true, true}); 371 ValidatePacketLossStatistics(tracker, 1.0f / 5.0f, 1.0f / 4.0f);
391 ValidatePacketLossStatistics(tracker, 1.0f / 5.0f, 1.0f / 4.0f); 372
392 373 // Expected window contents: [10111] -> [10111-GAP-10101].
393 // Expected window contents: [10111] -> [10111-GAP-10101]. 374 AddTransportFeedbackAndValidate(&tracker, base_ + 7,
394 AddTransportFeedbackAndValidate(&tracker, base + 7, 375 {true, false, true, false, true});
395 {true, false, true, false, true}); 376 ValidatePacketLossStatistics(tracker, 3.0f / 10.0f, 3.0f / 8.0f);
396 ValidatePacketLossStatistics(tracker, 3.0f / 10.0f, 3.0f / 8.0f); 377
397 378 // Insert in between, closing the gap completely.
398 // Insert in between, closing the gap completely. 379 // Expected window contents: [10111-GAP-10101] -> [101111010101].
399 // Expected window contents: [10111-GAP-10101] -> [101111010101]. 380 AddTransportFeedbackAndValidate(&tracker, base_ + 5, {false, true});
400 AddTransportFeedbackAndValidate(&tracker, base + 5, {false, true}); 381 ValidatePacketLossStatistics(tracker, 4.0f / 12.0f, 4.0f / 11.0f);
401 ValidatePacketLossStatistics(tracker, 4.0f / 12.0f, 4.0f / 11.0f);
402 }
403 } 382 }
404 383
405 // The window can meaningfully hold up to 0x8000 SENT packets (of which only 384 // The window can meaningfully hold up to 0x8000 SENT packets (of which only
406 // up to max-window acked messages will be kept and regarded). 385 // up to max-window acked messages will be kept and regarded).
407 TEST(TransportFeedbackPacketLossTrackerTest, SecondQuadrant) { 386 TEST_P(TransportFeedbackPacketLossTrackerTest, SecondQuadrant) {
408 for (uint16_t base : kBases) { 387 TransportFeedbackPacketLossTracker tracker(20, 5, 1);
409 TransportFeedbackPacketLossTracker tracker(20, 5, 1); 388
410 389 SendPacketRange(&tracker, base_, 0x8000, false);
411 SendPacketRange(&tracker, base, 0x8000, false); 390
412 391 // Expected window contents: [] -> [10011].
413 // Expected window contents: [] -> [10011]. 392 AddTransportFeedbackAndValidate(&tracker, base_,
414 AddTransportFeedbackAndValidate(&tracker, base, 393 {true, false, false, true, true});
415 {true, false, false, true, true}); 394 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f);
416 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 1.0f / 4.0f); 395
417 396 // Window *does* get updated with inputs from quadrant #2.
418 // Window *does* get updated with inputs from quadrant #2. 397 // Expected window contents: [10011] -> [100111].
419 // Expected window contents: [10011] -> [100111]. 398 AddTransportFeedbackAndValidate(&tracker, base_ + 0x4321, {true});
420 AddTransportFeedbackAndValidate(&tracker, base + 0x4321, {true}); 399 ValidatePacketLossStatistics(tracker, 2.0f / 6.0f, 1.0f / 4.0f);
421 ValidatePacketLossStatistics(tracker, 2.0f / 6.0f, 1.0f / 4.0f); 400
422 401 // Correct recognition of quadrant #2: up to, but not including, base_ +
423 // Correct recognition of quadrant #2: up to, but not including, base + 402 // 0x8000
424 // 0x8000 403 // Expected window contents: [100111] -> [1001111].
425 // Expected window contents: [100111] -> [1001111]. 404 AddTransportFeedbackAndValidate(&tracker, base_ + 0x7fff, {true});
426 AddTransportFeedbackAndValidate(&tracker, base + 0x7fff, {true}); 405 ValidatePacketLossStatistics(tracker, 2.0f / 7.0f, 1.0f / 4.0f);
427 ValidatePacketLossStatistics(tracker, 2.0f / 7.0f, 1.0f / 4.0f);
428 }
429 } 406 }
430 407
431 // After the base has moved due to insertion into the third quadrant, it is 408 // After the base has moved due to insertion into the third quadrant, it is
432 // still possible to get feedbacks in the middle of the window and obtain the 409 // still possible to get feedbacks in the middle of the window and obtain the
433 // correct PLR and RPLR. Insertion into the middle before the max window size 410 // correct PLR and RPLR. Insertion into the middle before the max window size
434 // has been achieved does not cause older packets to be dropped. 411 // has been achieved does not cause older packets to be dropped.
435 TEST(TransportFeedbackPacketLossTrackerTest, InsertIntoMiddleAfterBaseMoved) { 412 TEST_P(TransportFeedbackPacketLossTrackerTest, InsertIntoMiddleAfterBaseMoved) {
436 for (uint16_t base : kBases) { 413 TransportFeedbackPacketLossTracker tracker(20, 5, 1);
437 TransportFeedbackPacketLossTracker tracker(20, 5, 1); 414
438 415 SendPacketRange(&tracker, base_, 20);
439 SendPacketRange(&tracker, base, 20); 416 SendPacketRange(&tracker, base_ + 0x5000, 20);
440 SendPacketRange(&tracker, base + 0x5000, 20); 417
441 418 // Expected window contents: [] -> [1001101].
442 // Expected window contents: [] -> [1001101]. 419 AddTransportFeedbackAndValidate(
443 AddTransportFeedbackAndValidate( 420 &tracker, base_, {true, false, false, true, true, false, true});
444 &tracker, base, {true, false, false, true, true, false, true}); 421 ValidatePacketLossStatistics(tracker, 3.0f / 7.0f, 2.0f / 6.0f);
445 ValidatePacketLossStatistics(tracker, 3.0f / 7.0f, 2.0f / 6.0f); 422
446 423 // Expected window contents: [1001101] -> [101-GAP-1001].
447 // Expected window contents: [1001101] -> [101-GAP-1001]. 424 SendPacketRange(&tracker, base_ + 0x8000, 4);
448 SendPacketRange(&tracker, base + 0x8000, 4); 425 AddTransportFeedbackAndValidate(&tracker, base_ + 0x8000,
449 AddTransportFeedbackAndValidate(&tracker, base + 0x8000, 426 {true, false, false, true});
450 {true, false, false, true}); 427 ValidatePacketLossStatistics(tracker, 3.0f / 7.0f, 2.0f / 5.0f);
451 ValidatePacketLossStatistics(tracker, 3.0f / 7.0f, 2.0f / 5.0f); 428
452 429 // Inserting into the middle still works after the base has shifted.
453 // Inserting into the middle still works after the base has shifted. 430 // Expected window contents:
454 // Expected window contents: 431 // [101-GAP-1001] -> [101-GAP-100101-GAP-1001]
455 // [101-GAP-1001] -> [101-GAP-100101-GAP-1001] 432 AddTransportFeedbackAndValidate(&tracker, base_ + 0x5000,
456 AddTransportFeedbackAndValidate(&tracker, base + 0x5000, 433 {true, false, false, true, false, true});
457 {true, false, false, true, false, true}); 434 ValidatePacketLossStatistics(tracker, 6.0f / 13.0f, 4.0f / 10.0f);
458 ValidatePacketLossStatistics(tracker, 6.0f / 13.0f, 4.0f / 10.0f); 435
459 436 // The base can keep moving after inserting into the middle.
460 // The base can keep moving after inserting into the middle. 437 // Expected window contents:
461 // Expected window contents: 438 // [101-GAP-100101-GAP-1001] -> [1-GAP-100101-GAP-100111].
462 // [101-GAP-100101-GAP-1001] -> [1-GAP-100101-GAP-100111]. 439 SendPacketRange(&tracker, base_ + 0x8000 + 4, 2);
463 SendPacketRange(&tracker, base + 0x8000 + 4, 2); 440 AddTransportFeedbackAndValidate(&tracker, base_ + 0x8000 + 4, {true, true});
464 AddTransportFeedbackAndValidate(&tracker, base + 0x8000 + 4, {true, true}); 441 ValidatePacketLossStatistics(tracker, 5.0f / 13.0f, 3.0f / 10.0f);
465 ValidatePacketLossStatistics(tracker, 5.0f / 13.0f, 3.0f / 10.0f);
466 }
467 } 442 }
468 443
469 // After moving the base of the window, the max window size is still observed. 444 // After moving the base of the window, the max window size is still observed.
470 TEST(TransportFeedbackPacketLossTrackerTest, MaxWindowObservedAfterBaseMoved) { 445 TEST_P(TransportFeedbackPacketLossTrackerTest,
471 for (uint16_t base : kBases) { 446 MaxWindowObservedAfterBaseMoved) {
472 TransportFeedbackPacketLossTracker tracker(15, 10, 1); 447 TransportFeedbackPacketLossTracker tracker(15, 10, 1);
473 448
474 // Expected window contents: [] -> [1001110101]. 449 // Expected window contents: [] -> [1001110101].
475 SendPacketRange(&tracker, base, 10); 450 SendPacketRange(&tracker, base_, 10);
476 AddTransportFeedbackAndValidate( 451 AddTransportFeedbackAndValidate(
477 &tracker, base, 452 &tracker, base_,
478 {true, false, false, true, true, true, false, true, false, true}); 453 {true, false, false, true, true, true, false, true, false, true});
479 ValidatePacketLossStatistics(tracker, 4.0f / 10.0f, 3.0f / 9.0f); 454 ValidatePacketLossStatistics(tracker, 4.0f / 10.0f, 3.0f / 9.0f);
480 455
481 // Create gap (on both sides). 456 // Create gap (on both sides).
482 SendPacketRange(&tracker, base + 0x4000, 20); 457 SendPacketRange(&tracker, base_ + 0x4000, 20);
483 458
484 // Expected window contents: [1001110101] -> [1110101-GAP-101]. 459 // Expected window contents: [1001110101] -> [1110101-GAP-101].
485 SendPacketRange(&tracker, base + 0x8000, 3); 460 SendPacketRange(&tracker, base_ + 0x8000, 3);
486 AddTransportFeedbackAndValidate(&tracker, base + 0x8000, 461 AddTransportFeedbackAndValidate(&tracker, base_ + 0x8000,
487 {true, false, true}); 462 {true, false, true});
488 ValidatePacketLossStatistics(tracker, 3.0f / 10.0f, 3.0f / 8.0f); 463 ValidatePacketLossStatistics(tracker, 3.0f / 10.0f, 3.0f / 8.0f);
489 464
490 // Push into middle until max window is reached. The gap is NOT completed. 465 // Push into middle until max window is reached. The gap is NOT completed.
491 // Expected window contents: 466 // Expected window contents:
492 // [1110101-GAP-101] -> [1110101-GAP-10001-GAP-101] 467 // [1110101-GAP-101] -> [1110101-GAP-10001-GAP-101]
493 AddTransportFeedbackAndValidate(&tracker, base + 0x4000 + 2, 468 AddTransportFeedbackAndValidate(&tracker, base_ + 0x4000 + 2,
494 {true, false, false, false, true}); 469 {true, false, false, false, true});
495 ValidatePacketLossStatistics(tracker, 6.0f / 15.0f, 4.0f / 12.0f); 470 ValidatePacketLossStatistics(tracker, 6.0f / 15.0f, 4.0f / 12.0f);
496 471
497 // Pushing new packets into the middle would discard older packets. 472 // Pushing new packets into the middle would discard older packets.
498 // Expected window contents: 473 // Expected window contents:
499 // [1110101-GAP-10001-GAP-101] -> [0101-GAP-10001101-GAP-101] 474 // [1110101-GAP-10001-GAP-101] -> [0101-GAP-10001101-GAP-101]
500 AddTransportFeedbackAndValidate(&tracker, base + 0x4000 + 2 + 5, 475 AddTransportFeedbackAndValidate(&tracker, base_ + 0x4000 + 2 + 5,
501 {true, false, true}); 476 {true, false, true});
502 ValidatePacketLossStatistics(tracker, 7.0f / 15.0f, 5.0f / 12.0f); 477 ValidatePacketLossStatistics(tracker, 7.0f / 15.0f, 5.0f / 12.0f);
503 }
504 } 478 }
505 479
506 // A packet with a new enough sequence number might shift enough old feedbacks 480 // A packet with a new enough sequence number might shift enough old feedbacks
507 // out window, that we'd go back to an unknown PLR and RPLR. 481 // out window, that we'd go back to an unknown PLR and RPLR.
508 TEST(TransportFeedbackPacketLossTrackerTest, NewPacketMovesWindowBase) { 482 TEST_P(TransportFeedbackPacketLossTrackerTest, NewPacketMovesWindowBase) {
509 for (uint16_t base : kBases) { 483 TransportFeedbackPacketLossTracker tracker(20, 5, 3);
510 TransportFeedbackPacketLossTracker tracker(20, 5, 3); 484
511 485 SendPacketRange(&tracker, base_, 50);
512 SendPacketRange(&tracker, base, 50); 486 SendPacketRange(&tracker, base_ + 0x4000 - 1, 6); // Gap
513 SendPacketRange(&tracker, base + 0x4000 - 1, 6); // Gap 487
514 488 // Expected window contents: [] -> [1001110101].
515 // Expected window contents: [] -> [1001110101]. 489 AddTransportFeedbackAndValidate(
516 AddTransportFeedbackAndValidate( 490 &tracker, base_,
517 &tracker, base, 491 {true, false, false, true, true, true, false, true, false, true});
518 {true, false, false, true, true, true, false, true, false, true}); 492 ValidatePacketLossStatistics(tracker, 4.0f / 10.0f, 3.0f / 9.0f);
519 ValidatePacketLossStatistics(tracker, 4.0f / 10.0f, 3.0f / 9.0f); 493
520 494 // A new sent packet with a new enough sequence number could shift enough
521 // A new sent packet with a new enough sequence number could shift enough 495 // acked packets out of window, that we'd go back to an unknown PLR
522 // acked packets out of window, that we'd go back to an unknown PLR 496 // and RPLR. This *doesn't* // necessarily mean all of the old ones
523 // and RPLR. This *doesn't* // necessarily mean all of the old ones 497 // were discarded, though.
524 // were discarded, though. 498 // Expected window contents: [1001110101] -> [01].
525 // Expected window contents: [1001110101] -> [01]. 499 SendPacketRange(&tracker, base_ + 0x8006, 2);
526 SendPacketRange(&tracker, base + 0x8006, 2); 500 ValidatePacketLossStatistics(tracker,
527 ValidatePacketLossStatistics(tracker, 501 rtc::Optional<float>(), // Still invalid.
528 rtc::Optional<float>(), // Still invalid. 502 rtc::Optional<float>());
529 rtc::Optional<float>()); 503
530 504 // Even if those messages are acked, we'd still might be in unknown PLR
531 // Even if those messages are acked, we'd still might be in unknown PLR 505 // and RPLR, because we might have shifted more packets out of the window
532 // and RPLR, because we might have shifted more packets out of the window 506 // than we have inserted.
533 // than we have inserted. 507 // Expected window contents: [01] -> [01-GAP-11].
534 // Expected window contents: [01] -> [01-GAP-11]. 508 AddTransportFeedbackAndValidate(&tracker, base_ + 0x8006, {true, true});
535 AddTransportFeedbackAndValidate(&tracker, base + 0x8006, {true, true}); 509 ValidatePacketLossStatistics(tracker,
536 ValidatePacketLossStatistics(tracker, 510 rtc::Optional<float>(), // Still invalid.
537 rtc::Optional<float>(), // Still invalid. 511 rtc::Optional<float>());
538 rtc::Optional<float>()); 512
539 513 // Inserting in the middle shows that though some of the elements were
540 // Inserting in the middle shows that though some of the elements were 514 // ejected, some were retained.
541 // ejected, some were retained. 515 // Expected window contents: [01-GAP-11] -> [01-GAP-1001-GAP-11].
542 // Expected window contents: [01-GAP-11] -> [01-GAP-1001-GAP-11]. 516 AddTransportFeedbackAndValidate(&tracker, base_ + 0x4000,
543 AddTransportFeedbackAndValidate(&tracker, base + 0x4000, 517 {true, false, false, true});
544 {true, false, false, true}); 518 ValidatePacketLossStatistics(tracker, 3.0f / 8.0f, 2.0f / 5.0f);
545 ValidatePacketLossStatistics(tracker, 3.0f / 8.0f, 2.0f / 5.0f);
546 }
547 } 519 }
548 520
549 // Sequence number gaps are not gaps in reception. However, gaps in reception 521 // Sequence number gaps are not gaps in reception. However, gaps in reception
550 // are still possible, if a packet which WAS sent on the stream is not acked. 522 // are still possible, if a packet which WAS sent on the stream is not acked.
551 TEST(TransportFeedbackPacketLossTrackerTest, SanityGapsInSequenceNumbers) { 523 TEST_P(TransportFeedbackPacketLossTrackerTest, SanityGapsInSequenceNumbers) {
552 for (uint16_t base : kBases) { 524 TransportFeedbackPacketLossTracker tracker(20, 5, 1);
553 TransportFeedbackPacketLossTracker tracker(20, 5, 1); 525
554 526 SendPackets(&tracker, {static_cast<uint16_t>(base_),
555 SendPackets(&tracker, {static_cast<uint16_t>(base), 527 static_cast<uint16_t>(base_ + 2),
556 static_cast<uint16_t>(base + 2), 528 static_cast<uint16_t>(base_ + 4),
557 static_cast<uint16_t>(base + 4), 529 static_cast<uint16_t>(base_ + 6),
558 static_cast<uint16_t>(base + 6), 530 static_cast<uint16_t>(base_ + 8)});
559 static_cast<uint16_t>(base + 8)}); 531
560 532 // Gaps in sequence numbers not considered as gaps in window, because only
561 // Gaps in sequence numbers not considered as gaps in window, because only 533 // those sequence numbers which were associated with the stream count.
562 // those sequence numbers which were associated with the stream count. 534 // Expected window contents: [] -> [11011].
563 // Expected window contents: [] -> [11011]. 535 AddTransportFeedbackAndValidate(
564 AddTransportFeedbackAndValidate( 536 // Note: Left packets belong to this stream, odd ones ignored.
565 // Note: Left packets belong to this stream, odd ones ignored. 537 &tracker, base_, {true, false,
566 &tracker, base, {true, false, 538 true, false,
567 true, false, 539 false, false,
568 false, false, 540 true, false,
569 true, false, 541 true, true});
570 true, true}); 542 ValidatePacketLossStatistics(tracker, 1.0f / 5.0f, 1.0f / 4.0f);
571 ValidatePacketLossStatistics(tracker, 1.0f / 5.0f, 1.0f / 4.0f); 543
572 544 // Create gap by sending [base + 10] but not acking it.
573 // Create gap by sending [base + 10] but not acking it. 545 // Note: Acks for [base + 11] and [base + 13] ignored (other stream).
574 // Note: Acks for [base + 11] and [base + 13] ignored (other stream). 546 // Expected window contents: [11011] -> [11011-GAP-01].
575 // Expected window contents: [11011] -> [11011-GAP-01]. 547 SendPackets(&tracker, {static_cast<uint16_t>(base_ + 10),
576 SendPackets(&tracker, {static_cast<uint16_t>(base + 10), 548 static_cast<uint16_t>(base_ + 12),
577 static_cast<uint16_t>(base + 12), 549 static_cast<uint16_t>(base_ + 14)});
578 static_cast<uint16_t>(base + 14)}); 550 AddTransportFeedbackAndValidate(&tracker, base_ + 11,
579 AddTransportFeedbackAndValidate(&tracker, base + 11, 551 {false, false, false, true, true});
580 {false, false, false, true, true}); 552 ValidatePacketLossStatistics(tracker, 2.0f / 7.0f, 2.0f / 5.0f);
581 ValidatePacketLossStatistics(tracker, 2.0f / 7.0f, 2.0f / 5.0f);
582 }
583 } 553 }
584 554
585 // Sending a packet which is less than 0x8000 away from the baseline does 555 // Sending a packet which is less than 0x8000 away from the baseline does
586 // not move the window. 556 // not move the window.
587 TEST(TransportFeedbackPacketLossTrackerTest, UnackedInWindowDoesNotMoveWindow) { 557 TEST_P(TransportFeedbackPacketLossTrackerTest,
588 for (uint16_t base : kBases) { 558 UnackedInWindowDoesNotMoveWindow) {
589 TransportFeedbackPacketLossTracker tracker(5, 3, 1); 559 TransportFeedbackPacketLossTracker tracker(5, 3, 1);
590 560
591 // Baseline - window has acked messages. 561 // Baseline - window has acked messages.
592 // Expected window contents: [] -> [10101]. 562 // Expected window contents: [] -> [10101].
593 SendPacketRange(&tracker, base, 5); 563 SendPacketRange(&tracker, base_, 5);
594 AddTransportFeedbackAndValidate(&tracker, base, 564 AddTransportFeedbackAndValidate(&tracker, base_,
595 {true, false, true, false, true}); 565 {true, false, true, false, true});
596 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 2.0f / 4.0f); 566 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 2.0f / 4.0f);
597 567
598 // Test - window not moved. 568 // Test - window not moved.
599 // Expected window contents: [10101] -> [10101]. 569 // Expected window contents: [10101] -> [10101].
600 SendPackets(&tracker, {static_cast<uint16_t>(base + 0x7fff)}); 570 SendPackets(&tracker, {static_cast<uint16_t>(base_ + 0x7fff)});
601 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 2.0f / 4.0f); 571 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 2.0f / 4.0f);
602 }
603 } 572 }
604 573
605 // Sending a packet which is at least 0x8000 away from the baseline, but not 574 // Sending a packet which is at least 0x8000 away from the baseline, but not
606 // 0x8000 or more away from the newest packet in the window, moves the window, 575 // 0x8000 or more away from the newest packet in the window, moves the window,
607 // but does not reset it. 576 // but does not reset it.
608 TEST(TransportFeedbackPacketLossTrackerTest, UnackedOutOfWindowMovesWindow) { 577 TEST_P(TransportFeedbackPacketLossTrackerTest, UnackedOutOfWindowMovesWindow) {
609 for (uint16_t base : kBases) { 578 TransportFeedbackPacketLossTracker tracker(5, 3, 1);
610 TransportFeedbackPacketLossTracker tracker(5, 3, 1); 579
611 580 // Baseline - window has acked messages.
612 // Baseline - window has acked messages. 581 // Expected window contents: [] -> [10101].
613 // Expected window contents: [] -> [10101]. 582 SendPacketRange(&tracker, base_, 5);
614 SendPacketRange(&tracker, base, 5); 583 AddTransportFeedbackAndValidate(&tracker, base_,
615 AddTransportFeedbackAndValidate(&tracker, base, 584 {true, false, true, false, true});
616 {true, false, true, false, true}); 585 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 2.0f / 4.0f);
617 ValidatePacketLossStatistics(tracker, 2.0f / 5.0f, 2.0f / 4.0f); 586
618 587 // 0x8000 from baseline, but only 0x7ffc from newest - window moved.
619 // 0x8000 from baseline, but only 0x7ffc from newest - window moved. 588 // Expected window contents: [10101] -> [0101].
620 // Expected window contents: [10101] -> [0101]. 589 SendPackets(&tracker, {static_cast<uint16_t>(base_ + 0x8000)});
621 SendPackets(&tracker, {static_cast<uint16_t>(base + 0x8000)}); 590 ValidatePacketLossStatistics(tracker, 2.0f / 4.0f, 2.0f / 3.0f);
622 ValidatePacketLossStatistics(tracker, 2.0f / 4.0f, 2.0f / 3.0f);
623 }
624 } 591 }
625 592
626 // TODO(elad.alon): More tests possible here, but a CL is in the pipeline which 593 // TODO(elad.alon): More tests possible here, but a CL is in the pipeline which
627 // significantly changes the entire class's operation (makes the window 594 // significantly changes the entire class's operation (makes the window
628 // time-based), so no sense in writing complicated UTs which will be replaced 595 // time-based), so no sense in writing complicated UTs which will be replaced
629 // very soon. 596 // very soon.
630 597
631 // The window is reset by the sending of a packet which is 0x8000 or more 598 // The window is reset by the sending of a packet which is 0x8000 or more
632 // away from the newest packet. 599 // away from the newest packet.
633 TEST(TransportFeedbackPacketLossTrackerTest, WindowResetAfterLongNoSend) { 600 TEST_P(TransportFeedbackPacketLossTrackerTest, WindowResetAfterLongNoSend) {
634 for (uint16_t base : kBases) { 601 TransportFeedbackPacketLossTracker tracker(10, 2, 1);
635 TransportFeedbackPacketLossTracker tracker(10, 2, 1);
636 602
637 // Baseline - window has acked messages. 603 // Baseline - window has acked messages.
638 // Expected window contents: [] -> [1-GAP-10101]. 604 // Expected window contents: [] -> [1-GAP-10101].
639 SendPacketRange(&tracker, base, 1); 605 SendPacketRange(&tracker, base_, 1);
640 SendPacketRange(&tracker, base + 0x7fff - 4, 5); 606 SendPacketRange(&tracker, base_ + 0x7fff - 4, 5);
641 AddTransportFeedbackAndValidate(&tracker, base, {true}); 607 AddTransportFeedbackAndValidate(&tracker, base_, {true});
642 AddTransportFeedbackAndValidate(&tracker, base + 0x7fff - 4, 608 AddTransportFeedbackAndValidate(&tracker, base_ + 0x7fff - 4,
643 {true, false, true, false, true}); 609 {true, false, true, false, true});
644 ValidatePacketLossStatistics(tracker, 2.0f / 6.0f, 2.0f / 5.0f); 610 ValidatePacketLossStatistics(tracker, 2.0f / 6.0f, 2.0f / 5.0f);
645 611
646 // Sent packet too new - the entire window is reset. 612 // Sent packet too new - the entire window is reset.
647 // Expected window contents: [1-GAP-10101] -> []. 613 // Expected window contents: [1-GAP-10101] -> [].
648 SendPacketRange(&tracker, base + 0x7fff + 0x8000, 1); 614 SendPacketRange(&tracker, base_ + 0x7fff + 0x8000, 1);
649 ValidatePacketLossStatistics(tracker, 615 ValidatePacketLossStatistics(tracker,
650 rtc::Optional<float>(), 616 rtc::Optional<float>(),
651 rtc::Optional<float>()); 617 rtc::Optional<float>());
652 618
653 // To show it was really reset, prove show that acking the sent packet 619 // To show it was really reset, prove show that acking the sent packet
654 // still leaves us at unknown, because no acked (or unacked) packets were 620 // still leaves us at unknown, because no acked (or unacked) packets were
655 // left in the window. 621 // left in the window.
656 // Expected window contents: [] -> [1]. 622 // Expected window contents: [] -> [1].
657 AddTransportFeedbackAndValidate(&tracker, base + 0x7fff + 0x8000, {true}); 623 AddTransportFeedbackAndValidate(&tracker, base_ + 0x7fff + 0x8000, {true});
658 ValidatePacketLossStatistics(tracker, 624 ValidatePacketLossStatistics(tracker,
659 rtc::Optional<float>(), 625 rtc::Optional<float>(),
660 rtc::Optional<float>()); 626 rtc::Optional<float>());
661 }
662 } 627 }
663 628
629 // All tests are run multiple times with various baseline sequence number,
630 // to weed out potential bugs with wrap-around handling.
631 constexpr uint16_t kBases[] = {0x0000, 0x3456, 0xc032, 0xfffe};
632
633 INSTANTIATE_TEST_CASE_P(_,
634 TransportFeedbackPacketLossTrackerTest,
635 testing::ValuesIn(kBases));
636
664 } // namespace webrtc 637 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698