Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2668973003: Revert of Always call RemoteBitrateEstimator::IncomingPacket from Call. (Closed)

Created:
3 years, 10 months ago by nisse-webrtc
Modified:
3 years, 10 months ago
Reviewers:
brandtr, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, the sun, mflodman, philipel
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Always call RemoteBitrateEstimator::IncomingPacket from Call. (patchset #9 id:160001 of https://codereview.webrtc.org/2659563002/ ) Reason for revert: This change causes excessive logging when running tests, and possibly also broke perf tests, see https://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/builds/1040/steps/webrtc_perf_tests/logs/stdio Original issue's description: > Always call RemoteBitrateEstimator::IncomingPacket from Call. > > Delete the calls from RtpStreamReceiver (for video) and > AudioReceiveStream. > > BUG=webrtc:6847 > > Review-Url: https://codereview.webrtc.org/2659563002 > Cr-Commit-Position: refs/heads/master@{#16393} > Committed: https://chromium.googlesource.com/external/webrtc/+/6d4dd593a824cfc9c67f6e9fd3a08014d08350a0 TBR=stefan@webrtc.org,brandtr@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6847 Review-Url: https://codereview.webrtc.org/2668973003 Cr-Commit-Position: refs/heads/master@{#16400} Committed: https://chromium.googlesource.com/external/webrtc/+/14245cc9397284cabab5057c0c661953e2d0cdec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -77 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M webrtc/call/call.cc View 16 chunks +31 lines, -77 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nisse-webrtc
Created Revert of Always call RemoteBitrateEstimator::IncomingPacket from Call.
3 years, 10 months ago (2017-02-01 16:10:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668973003/1
3 years, 10 months ago (2017-02-01 16:10:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/14245cc9397284cabab5057c0c661953e2d0cdec
3 years, 10 months ago (2017-02-01 16:10:45 UTC) #6
nisse-webrtc
3 years, 10 months ago (2017-02-02 08:19:55 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2673523003/ by nisse@webrtc.org.

The reason for reverting is: Intending to fix issues and reland..

Powered by Google App Engine
This is Rietveld 408576698