Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: webrtc/audio/audio_receive_stream_unittest.cc

Issue 2668973003: Revert of Always call RemoteBitrateEstimator::IncomingPacket from Call. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio/audio_receive_stream.cc ('k') | webrtc/call/call.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 } 241 }
242 242
243 TEST(AudioReceiveStreamTest, ConstructDestruct) { 243 TEST(AudioReceiveStreamTest, ConstructDestruct) {
244 ConfigHelper helper; 244 ConfigHelper helper;
245 internal::AudioReceiveStream recv_stream( 245 internal::AudioReceiveStream recv_stream(
246 helper.packet_router(), 246 helper.packet_router(),
247 helper.remote_bitrate_estimator(), 247 helper.remote_bitrate_estimator(),
248 helper.config(), helper.audio_state(), helper.event_log()); 248 helper.config(), helper.audio_state(), helper.event_log());
249 } 249 }
250 250
251 MATCHER_P(VerifyHeaderExtension, expected_extension, "") {
252 return arg.extension.hasTransportSequenceNumber ==
253 expected_extension.hasTransportSequenceNumber &&
254 arg.extension.transportSequenceNumber ==
255 expected_extension.transportSequenceNumber;
256 }
257
251 TEST(AudioReceiveStreamTest, ReceiveRtpPacket) { 258 TEST(AudioReceiveStreamTest, ReceiveRtpPacket) {
252 ConfigHelper helper; 259 ConfigHelper helper;
253 helper.config().rtp.transport_cc = true; 260 helper.config().rtp.transport_cc = true;
254 helper.SetupMockForBweFeedback(true); 261 helper.SetupMockForBweFeedback(true);
255 internal::AudioReceiveStream recv_stream( 262 internal::AudioReceiveStream recv_stream(
256 helper.packet_router(), 263 helper.packet_router(),
257 helper.remote_bitrate_estimator(), 264 helper.remote_bitrate_estimator(),
258 helper.config(), helper.audio_state(), helper.event_log()); 265 helper.config(), helper.audio_state(), helper.event_log());
259 const int kTransportSequenceNumberValue = 1234; 266 const int kTransportSequenceNumberValue = 1234;
260 std::vector<uint8_t> rtp_packet = CreateRtpHeaderWithOneByteExtension( 267 std::vector<uint8_t> rtp_packet = CreateRtpHeaderWithOneByteExtension(
261 kTransportSequenceNumberId, kTransportSequenceNumberValue, 2); 268 kTransportSequenceNumberId, kTransportSequenceNumberValue, 2);
262 PacketTime packet_time(5678000, 0); 269 PacketTime packet_time(5678000, 0);
270 const size_t kExpectedHeaderLength = 20;
271 RTPHeaderExtension expected_extension;
272 expected_extension.hasTransportSequenceNumber = true;
273 expected_extension.transportSequenceNumber = kTransportSequenceNumberValue;
274 EXPECT_CALL(*helper.remote_bitrate_estimator(),
275 IncomingPacket(packet_time.timestamp / 1000,
276 rtp_packet.size() - kExpectedHeaderLength,
277 VerifyHeaderExtension(expected_extension)))
278 .Times(1);
263 EXPECT_CALL(*helper.channel_proxy(), 279 EXPECT_CALL(*helper.channel_proxy(),
264 ReceivedRTPPacket(&rtp_packet[0], 280 ReceivedRTPPacket(&rtp_packet[0],
265 rtp_packet.size(), 281 rtp_packet.size(),
266 _)) 282 _))
267 .WillOnce(Return(true)); 283 .WillOnce(Return(true));
268 EXPECT_TRUE( 284 EXPECT_TRUE(
269 recv_stream.DeliverRtp(&rtp_packet[0], rtp_packet.size(), packet_time)); 285 recv_stream.DeliverRtp(&rtp_packet[0], rtp_packet.size(), packet_time));
270 } 286 }
271 287
272 TEST(AudioReceiveStreamTest, ReceiveRtcpPacket) { 288 TEST(AudioReceiveStreamTest, ReceiveRtcpPacket) {
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 380
365 EXPECT_CALL(helper.voice_engine(), StartPlayout(_)).WillOnce(Return(0)); 381 EXPECT_CALL(helper.voice_engine(), StartPlayout(_)).WillOnce(Return(0));
366 EXPECT_CALL(helper.voice_engine(), StopPlayout(_)); 382 EXPECT_CALL(helper.voice_engine(), StopPlayout(_));
367 EXPECT_CALL(*helper.audio_mixer(), AddSource(&recv_stream)) 383 EXPECT_CALL(*helper.audio_mixer(), AddSource(&recv_stream))
368 .WillOnce(Return(true)); 384 .WillOnce(Return(true));
369 385
370 recv_stream.Start(); 386 recv_stream.Start();
371 } 387 }
372 } // namespace test 388 } // namespace test
373 } // namespace webrtc 389 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/audio/audio_receive_stream.cc ('k') | webrtc/call/call.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698