Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2666923002: Reland of move usage of deprecated g_type_init API (Closed)

Created:
3 years, 10 months ago by oprypin_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of move usage of deprecated g_type_init API (patchset #1 id:1 of https://codereview.webrtc.org/2666103002/ ) Reason for revert: Relanding because breakage was not related to this change. Original issue's description: > Revert of Remove usage of deprecated g_type_init API (patchset #1 id:1 of https://codereview.webrtc.org/2660823003/ ) > > Reason for revert: > Reverting due to internal breakage. Will investigate and re-land > > Original issue's description: > > Remove usage of deprecated g_type_init API > > > > BUG=webrtc:7024 > > > > Review-Url: https://codereview.webrtc.org/2660823003 > > Cr-Commit-Position: refs/heads/master@{#16376} > > Committed: https://chromium.googlesource.com/external/webrtc/+/b2caab7f6078ed46d4bda5103d7f8c93b896a518 > > TBR=kjellander@webrtc.org,perkj@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7024 > > Review-Url: https://codereview.webrtc.org/2666103002 > Cr-Commit-Position: refs/heads/master@{#16379} > Committed: https://chromium.googlesource.com/external/webrtc/+/d1685ab547dcd4b362e44e99894123d2b171451c TBR=kjellander@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7024 Review-Url: https://codereview.webrtc.org/2666923002 Cr-Commit-Position: refs/heads/master@{#16380} Committed: https://chromium.googlesource.com/external/webrtc/+/6fb4f5696d9c07df3b04595db311ca5ca6e093ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M webrtc/examples/peerconnection/client/linux/main.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
oprypin_webrtc
Created Reland of move usage of deprecated g_type_init API
3 years, 10 months ago (2017-01-31 14:50:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2666923002/1
3 years, 10 months ago (2017-01-31 14:50:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/6fb4f5696d9c07df3b04595db311ca5ca6e093ea
3 years, 10 months ago (2017-01-31 14:50:18 UTC) #6
kjellander_webrtc
3 years, 10 months ago (2017-01-31 20:47:22 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698