Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2660823003: Remove usage of deprecated g_type_init API (Closed)

Created:
3 years, 10 months ago by oprypin_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove usage of deprecated g_type_init API BUG=webrtc:7024 Review-Url: https://codereview.webrtc.org/2660823003 Cr-Commit-Position: refs/heads/master@{#16376} Committed: https://chromium.googlesource.com/external/webrtc/+/b2caab7f6078ed46d4bda5103d7f8c93b896a518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M webrtc/examples/peerconnection/client/linux/main.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
oprypin_webrtc
3 years, 10 months ago (2017-01-30 17:50:06 UTC) #3
kjellander_webrtc
lgtm, but you need magjed@ as owner. (Magnus: this fails compilation for Linux ARM64)
3 years, 10 months ago (2017-01-30 20:07:16 UTC) #5
kjellander_webrtc
On 2017/01/30 20:07:16, kjellander_webrtc wrote: > lgtm, but you need magjed@ as owner. > (Magnus: ...
3 years, 10 months ago (2017-01-30 20:07:33 UTC) #6
kjellander_webrtc
Replacing with perkj@ as magjed@ is OOO.
3 years, 10 months ago (2017-01-31 09:55:44 UTC) #8
perkj_webrtc
lgtm
3 years, 10 months ago (2017-01-31 11:01:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2660823003/1
3 years, 10 months ago (2017-01-31 12:07:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/b2caab7f6078ed46d4bda5103d7f8c93b896a518
3 years, 10 months ago (2017-01-31 13:16:17 UTC) #16
oprypin_webrtc
3 years, 10 months ago (2017-01-31 14:09:13 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2666103002/ by oprypin@webrtc.org.

The reason for reverting is: Reverting due to internal breakage. Will
investigate and re-land.

Powered by Google App Engine
This is Rietveld 408576698