Issue 2665113006: Delete DeviceInfoImpl::GetExpectedCaptureDelay and related declarations.

Issue 2665113006: Delete DeviceInfoImpl::GetExpectedCaptureDelay and related declarations. (Closed)

Created:
3 years, 10 months ago by nisse-webrtc

Modified:
3 years, 10 months ago

Reviewers:
mflodman

CC:
webrtc-reviews_webrtc.org, zhengzhonghou_agora.io, tterriberry_mozilla.com, sdk-team_agora.io, the sun, perkj_webrtc, mflodman

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

Delete DeviceInfoImpl::GetExpectedCaptureDelay and related declarations. This feature is unused. We can then also delete the header file video_capture_delay.h. BUG=None Review-Url: https://codereview.webrtc.org/2665113006 Cr-Commit-Position: refs/heads/master@{#16666} Committed: https://chromium.googlesource.com/external/webrtc/+/642943baead06cf639400470fb537987aec11f9d

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -161 lines)			Patch
M	webrtc/media/engine/webrtcvideocapturer.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/modules/video_capture/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/modules/video_capture/device_info_impl.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	webrtc/modules/video_capture/device_info_impl.cc	View		1 chunk	+0 lines, -76 lines	0 comments	Download
M	webrtc/modules/video_capture/linux/device_info_linux.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/modules/video_capture/linux/video_capture_linux.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/modules/video_capture/objc/device_info_objc.mm	View	1	3 chunks	+0 lines, -6 lines	0 comments	Download
M	webrtc/modules/video_capture/video_capture_defines.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
D	webrtc/modules/video_capture/video_capture_delay.h	View		1 chunk	+0 lines, -36 lines	0 comments	Download
M	webrtc/modules/video_capture/video_capture_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/modules/video_capture/video_capture_impl.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/modules/video_capture/windows/device_info_ds.cc	View	1 2	3 chunks	+0 lines, -26 lines	0 comments	Download
M	webrtc/modules/video_capture/windows/video_capture_ds.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 8 (4 generated)

nisse-webrtc

PTAL, this also appears unused. The Chrome bot failure is due to the patch process ...

3 years, 10 months ago (2017-02-01 10:28:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2665113006/40001

3 years, 10 months ago (2017-02-17 12:19:59 UTC) #5

commit-bot: I haz the power

3 years, 10 months ago (2017-02-17 14:22:13 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/642943baead06cf639400470f...