Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: webrtc/modules/video_capture/windows/device_info_ds.cc

Issue 2665113006: Delete DeviceInfoImpl::GetExpectedCaptureDelay and related declarations. (Closed)
Patch Set: Drop include of video_capture_delay.h, and definition of WindowsCaptureDelays. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/modules/video_capture/windows/device_info_ds.h" 11 #include "webrtc/modules/video_capture/windows/device_info_ds.h"
12 12
13 #include "webrtc/modules/video_capture/video_capture_config.h" 13 #include "webrtc/modules/video_capture/video_capture_config.h"
14 #include "webrtc/modules/video_capture/video_capture_delay.h"
15 #include "webrtc/modules/video_capture/windows/help_functions_ds.h" 14 #include "webrtc/modules/video_capture/windows/help_functions_ds.h"
16 #include "webrtc/system_wrappers/include/trace.h" 15 #include "webrtc/system_wrappers/include/trace.h"
17 16
18 #include <Dvdmedia.h> 17 #include <Dvdmedia.h>
19 #include <Streams.h> 18 #include <Streams.h>
20 19
21 namespace webrtc 20 namespace webrtc
22 { 21 {
23 namespace videocapturemodule 22 namespace videocapturemodule
24 { 23 {
25 const int32_t NoWindowsCaptureDelays = 1;
26 const DelayValues WindowsCaptureDelays[NoWindowsCaptureDelays] = {
27 "Microsoft LifeCam Cinema",
28 "usb#vid_045e&pid_075d",
29 {
30 {640,480,125},
31 {640,360,117},
32 {424,240,111},
33 {352,288,111},
34 {320,240,116},
35 {176,144,101},
36 {160,120,109},
37 {1280,720,166},
38 {960,544,126},
39 {800,448,120},
40 {800,600,127}
41 },
42 };
43 24
44 // static 25 // static
45 DeviceInfoDS* DeviceInfoDS::Create() 26 DeviceInfoDS* DeviceInfoDS::Create()
46 { 27 {
47 DeviceInfoDS* dsInfo = new DeviceInfoDS(); 28 DeviceInfoDS* dsInfo = new DeviceInfoDS();
48 if (!dsInfo || dsInfo->Init() != 0) 29 if (!dsInfo || dsInfo->Init() != 0)
49 { 30 {
50 delete dsInfo; 31 delete dsInfo;
51 dsInfo = NULL; 32 dsInfo = NULL;
52 } 33 }
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 { 632 {
652 WCHAR strGuid[39]; 633 WCHAR strGuid[39];
653 StringFromGUID2(pmt->subtype, strGuid, 39); 634 StringFromGUID2(pmt->subtype, strGuid, 39);
654 WEBRTC_TRACE( webrtc::kTraceWarning, 635 WEBRTC_TRACE( webrtc::kTraceWarning,
655 webrtc::kTraceVideoCapture, 0, 636 webrtc::kTraceVideoCapture, 0,
656 "Device support unknown media type %ls, width %d, h eight %d", 637 "Device support unknown media type %ls, width %d, h eight %d",
657 strGuid); 638 strGuid);
658 continue; 639 continue;
659 } 640 }
660 641
661 // Get the expected capture delay from the static list
662 capability.expectedCaptureDelay
663 = GetExpectedCaptureDelay(WindowsCaptureDelays,
664 NoWindowsCaptureDelays,
665 productId,
666 capability.width,
667 capability.height);
668 _captureCapabilities.push_back(capability); 642 _captureCapabilities.push_back(capability);
669 _captureCapabilitiesWindows.push_back(capability); 643 _captureCapabilitiesWindows.push_back(capability);
670 WEBRTC_TRACE( webrtc::kTraceInfo, webrtc::kTraceVideoCapture, 0, 644 WEBRTC_TRACE( webrtc::kTraceInfo, webrtc::kTraceVideoCapture, 0,
671 "Camera capability, width:%d height:%d type:%d fps:%d", 645 "Camera capability, width:%d height:%d type:%d fps:%d",
672 capability.width, capability.height, 646 capability.width, capability.height,
673 capability.rawType, capability.maxFPS); 647 capability.rawType, capability.maxFPS);
674 } 648 }
675 DeleteMediaType(pmt); 649 DeleteMediaType(pmt);
676 pmt = NULL; 650 pmt = NULL;
677 } 651 }
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
792 // Release memory. 766 // Release memory.
793 if (uuid.pElems) 767 if (uuid.pElems)
794 { 768 {
795 CoTaskMemFree(uuid.pElems); 769 CoTaskMemFree(uuid.pElems);
796 } 770 }
797 filter->Release(); 771 filter->Release();
798 return 0; 772 return 0;
799 } 773 }
800 } // namespace videocapturemodule 774 } // namespace videocapturemodule
801 } // namespace webrtc 775 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_capture/video_capture_impl.cc ('k') | webrtc/modules/video_capture/windows/video_capture_ds.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698