Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2663063003: Enable cpplint and fix cpplint errors in webrtc/api (Closed)

Created:
3 years, 10 months ago by oprypin_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable cpplint and fix cpplint errors in webrtc/api Adding 'explicit' to these constructors has a low risk of causing compatibility problems: explicit RTCConfiguration(RTCConfigurationType type) explicit IdBase(StatsType type) BUG=webrtc:5267 TESTED=Fixed issues reported by: find webrtc/api -type f -name *.cc -o -name *.h | xargs cpplint.py followed by 'git cl presubmit'. Review-Url: https://codereview.webrtc.org/2663063003 Cr-Commit-Position: refs/heads/master@{#16392} Committed: https://chromium.googlesource.com/external/webrtc/+/803dc29bb6773b60dadf5b630ef6a00b8e72f77f

Patch Set 1 : Don't add PRESUBMIT yet so Chromium trybots can run #

Patch Set 2 : Enable cpplint and fix cpplint errors in webrtc/api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/datachannelinterface.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/fakemetricsobserver.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/jsepicecandidate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/mediaconstraintsinterface.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/mediastreamproxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/mediastreamtrackproxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/peerconnectionproxy.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/proxy.h View 5 chunks +7 lines, -6 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/statstypes.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/umametrics.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
oprypin_webrtc
3 years, 10 months ago (2017-01-31 15:38:50 UTC) #9
perkj_webrtc
On 2017/01/31 15:38:50, oprypin_webrtc wrote: thanks for fixing lgtm
3 years, 10 months ago (2017-01-31 18:58:41 UTC) #11
oprypin_webrtc
Added henrika@webrtc.org for review of PRESUBMIT.py
3 years, 10 months ago (2017-02-01 08:39:53 UTC) #13
henrika_webrtc
Great work. Thanks! LGTM
3 years, 10 months ago (2017-02-01 08:54:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2663063003/40001
3 years, 10 months ago (2017-02-01 09:53:23 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 09:56:03 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/803dc29bb6773b60dadf5b630...

Powered by Google App Engine
This is Rietveld 408576698