Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Side by Side Diff: webrtc/api/peerconnectioninterface.h

Issue 2663063003: Enable cpplint and fix cpplint errors in webrtc/api (Closed)
Patch Set: Enable cpplint and fix cpplint errors in webrtc/api Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/mediastreamtrackproxy.h ('k') | webrtc/api/peerconnectionproxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 // need getters and setters at least for fields which applications 281 // need getters and setters at least for fields which applications
282 // are interested in. 282 // are interested in.
283 struct RTCConfiguration { 283 struct RTCConfiguration {
284 // This struct is subject to reorganization, both for naming 284 // This struct is subject to reorganization, both for naming
285 // consistency, and to group settings to match where they are used 285 // consistency, and to group settings to match where they are used
286 // in the implementation. To do that, we need getter and setter 286 // in the implementation. To do that, we need getter and setter
287 // methods for all settings which are of interest to applications, 287 // methods for all settings which are of interest to applications,
288 // Chrome in particular. 288 // Chrome in particular.
289 289
290 RTCConfiguration() = default; 290 RTCConfiguration() = default;
291 RTCConfiguration(RTCConfigurationType type) { 291 explicit RTCConfiguration(RTCConfigurationType type) {
292 if (type == RTCConfigurationType::kAggressive) { 292 if (type == RTCConfigurationType::kAggressive) {
293 // These parameters are also defined in Java and IOS configurations, 293 // These parameters are also defined in Java and IOS configurations,
294 // so their values may be overwritten by the Java or IOS configuration. 294 // so their values may be overwritten by the Java or IOS configuration.
295 bundle_policy = kBundlePolicyMaxBundle; 295 bundle_policy = kBundlePolicyMaxBundle;
296 rtcp_mux_policy = kRtcpMuxPolicyRequire; 296 rtcp_mux_policy = kRtcpMuxPolicyRequire;
297 ice_connection_receiving_timeout = 297 ice_connection_receiving_timeout =
298 kAggressiveIceConnectionReceivingTimeout; 298 kAggressiveIceConnectionReceivingTimeout;
299 299
300 // These parameters are not defined in Java or IOS configuration, 300 // These parameters are not defined in Java or IOS configuration,
301 // so their values will not be overwritten. 301 // so their values will not be overwritten.
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 virtual void OnAddStream(MediaStreamInterface* stream) {} 662 virtual void OnAddStream(MediaStreamInterface* stream) {}
663 663
664 // Triggered when a remote peer close a stream. 664 // Triggered when a remote peer close a stream.
665 virtual void OnRemoveStream(rtc::scoped_refptr<MediaStreamInterface> stream) { 665 virtual void OnRemoveStream(rtc::scoped_refptr<MediaStreamInterface> stream) {
666 } 666 }
667 // Deprecated; please use the version that uses a scoped_refptr. 667 // Deprecated; please use the version that uses a scoped_refptr.
668 virtual void OnRemoveStream(MediaStreamInterface* stream) {} 668 virtual void OnRemoveStream(MediaStreamInterface* stream) {}
669 669
670 // Triggered when a remote peer opens a data channel. 670 // Triggered when a remote peer opens a data channel.
671 virtual void OnDataChannel( 671 virtual void OnDataChannel(
672 rtc::scoped_refptr<DataChannelInterface> data_channel){}; 672 rtc::scoped_refptr<DataChannelInterface> data_channel) {}
673 // Deprecated; please use the version that uses a scoped_refptr. 673 // Deprecated; please use the version that uses a scoped_refptr.
674 virtual void OnDataChannel(DataChannelInterface* data_channel) {} 674 virtual void OnDataChannel(DataChannelInterface* data_channel) {}
675 675
676 // Triggered when renegotiation is needed. For example, an ICE restart 676 // Triggered when renegotiation is needed. For example, an ICE restart
677 // has begun. 677 // has begun.
678 virtual void OnRenegotiationNeeded() = 0; 678 virtual void OnRenegotiationNeeded() = 0;
679 679
680 // Called any time the IceConnectionState changes. 680 // Called any time the IceConnectionState changes.
681 virtual void OnIceConnectionChange( 681 virtual void OnIceConnectionChange(
682 PeerConnectionInterface::IceConnectionState new_state) = 0; 682 PeerConnectionInterface::IceConnectionState new_state) = 0;
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 cricket::WebRtcVideoEncoderFactory* encoder_factory, 940 cricket::WebRtcVideoEncoderFactory* encoder_factory,
941 cricket::WebRtcVideoDecoderFactory* decoder_factory) { 941 cricket::WebRtcVideoDecoderFactory* decoder_factory) {
942 return CreatePeerConnectionFactory( 942 return CreatePeerConnectionFactory(
943 worker_and_network_thread, worker_and_network_thread, signaling_thread, 943 worker_and_network_thread, worker_and_network_thread, signaling_thread,
944 default_adm, encoder_factory, decoder_factory); 944 default_adm, encoder_factory, decoder_factory);
945 } 945 }
946 946
947 } // namespace webrtc 947 } // namespace webrtc
948 948
949 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ 949 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « webrtc/api/mediastreamtrackproxy.h ('k') | webrtc/api/peerconnectionproxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698