Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 2658233002: Wire up audio packet loss to BWE. (Closed)

Created:
3 years, 10 months ago by stefan-webrtc
Modified:
3 years, 10 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Wire up audio packet loss to BWE. BUG=webtrc:5079 Review-Url: https://codereview.webrtc.org/2658233002 Cr-Commit-Position: refs/heads/master@{#16474} Committed: https://chromium.googlesource.com/external/webrtc/+/7de8d64f89b51967ee7fa8ff2a07f716aee72c53

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix leak #

Patch Set 4 : Only register BandwidthObserver when needed BWE is negotiated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -40 lines) Patch
M webrtc/audio/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/audio/audio_send_stream.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 1 2 3 3 chunks +7 lines, -3 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 2 3 15 chunks +55 lines, -23 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +7 lines, -6 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 4 chunks +24 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
stefan-webrtc
3 years, 10 months ago (2017-02-03 14:50:28 UTC) #2
stefan-webrtc
.
3 years, 10 months ago (2017-02-03 15:01:05 UTC) #7
the sun
lgtm
3 years, 10 months ago (2017-02-06 22:07:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2658233002/40001
3 years, 10 months ago (2017-02-07 06:02:27 UTC) #14
stefan-webrtc
I had to make a change as I realized I don't want the RtcpBandwidthObserver (poor ...
3 years, 10 months ago (2017-02-07 08:54:06 UTC) #16
the sun
lgtm
3 years, 10 months ago (2017-02-07 14:49:22 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2658233002/60001
3 years, 10 months ago (2017-02-07 15:11:27 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 15:14:12 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/7de8d64f89b51967ee7fa8ff2...

Powered by Google App Engine
This is Rietveld 408576698