Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: webrtc/video/video_quality_test.cc

Issue 2658233002: Wire up audio packet loss to BWE. (Closed)
Patch Set: Only register BandwidthObserver when needed BWE is negotiated. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/test/mock_voe_channel_proxy.h ('k') | webrtc/voice_engine/channel.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/video/video_quality_test.h" 10 #include "webrtc/video/video_quality_test.h"
(...skipping 911 matching lines...) Expand 10 before | Expand all | Expand 10 after
922 ss << ", " << params_.screenshare.scroll_duration << "s scroll"; 922 ss << ", " << params_.screenshare.scroll_duration << "s scroll";
923 if (params_.ss.streams.size() > 1) 923 if (params_.ss.streams.size() > 1)
924 ss << ", Stream #" << params_.ss.selected_stream; 924 ss << ", Stream #" << params_.ss.selected_stream;
925 if (params_.ss.num_spatial_layers > 1) 925 if (params_.ss.num_spatial_layers > 1)
926 ss << ", Layer #" << params_.ss.selected_sl; 926 ss << ", Layer #" << params_.ss.selected_sl;
927 ss << ")"; 927 ss << ")";
928 return ss.str(); 928 return ss.str();
929 } 929 }
930 930
931 void VideoQualityTest::CheckParams() { 931 void VideoQualityTest::CheckParams() {
932 if (!params_.video.enabled)
933 return;
932 // Add a default stream in none specified. 934 // Add a default stream in none specified.
933 if (params_.ss.streams.empty()) 935 if (params_.ss.streams.empty())
934 params_.ss.streams.push_back(VideoQualityTest::DefaultVideoStream(params_)); 936 params_.ss.streams.push_back(VideoQualityTest::DefaultVideoStream(params_));
935 if (params_.ss.num_spatial_layers == 0) 937 if (params_.ss.num_spatial_layers == 0)
936 params_.ss.num_spatial_layers = 1; 938 params_.ss.num_spatial_layers = 1;
937 939
938 if (params_.pipe.loss_percent != 0 || 940 if (params_.pipe.loss_percent != 0 ||
939 params_.pipe.queue_length_packets != 0) { 941 params_.pipe.queue_length_packets != 0) {
940 // Since LayerFilteringTransport changes the sequence numbers, we can't 942 // Since LayerFilteringTransport changes the sequence numbers, we can't
941 // use that feature with pack loss, since the NACK request would end up 943 // use that feature with pack loss, since the NACK request would end up
(...skipping 646 matching lines...) Expand 10 before | Expand all | Expand 10 after
1588 std::ostringstream str; 1590 std::ostringstream str;
1589 str << receive_logs_++; 1591 str << receive_logs_++;
1590 std::string path = 1592 std::string path =
1591 params_.video.encoded_frame_base_path + "." + str.str() + ".recv.ivf"; 1593 params_.video.encoded_frame_base_path + "." + str.str() + ".recv.ivf";
1592 stream->EnableEncodedFrameRecording(rtc::CreatePlatformFile(path), 1594 stream->EnableEncodedFrameRecording(rtc::CreatePlatformFile(path),
1593 10000000); 1595 10000000);
1594 } 1596 }
1595 } 1597 }
1596 1598
1597 } // namespace webrtc 1599 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/test/mock_voe_channel_proxy.h ('k') | webrtc/voice_engine/channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698