Add QP for libvpx VP8 decoder.

Add QP for libvpx VP8 decoder.

BUG=webrtc:6541, webrtc:7065
TBR=hta@webrtc.org

Review-Url: https://codereview.webrtc.org/2656603002
Cr-Commit-Position: refs/heads/master@{#16722}
Committed: https://chromium.googlesource.com/external/webrtc/+/5fec128de94c0b2d0090de8eac692dce9aa23a80

[sakal, 2017-01-24 14:26:45]

Patchset #1 (id:1) has been deleted

[sakal, 2017-02-10 10:27:43]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 10:27:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-10 10:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:36:54]

Dry run: Try jobs failed on following builders:
  linux_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/21879)

[sakal, 2017-02-10 12:51:17]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 12:51:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-10 12:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 12:54:17]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17342)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/22599)

[sakal, 2017-02-10 13:12:56]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 13:13:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-10 13:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 13:16:34]

Dry run: Try jobs failed on following builders:
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21365)
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/5049)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/18603)

[sakal, 2017-02-10 13:58:09]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 13:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-10 14:11:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 14:11:40]

Dry run: Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/22934)

[sakal, 2017-02-10 14:18:36]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 14:18:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-10 16:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:28:05]

Dry run: This issue passed the CQ dry run.

[sakal, 2017-02-16 12:36:46]

Patchset #1 (id:20001) has been deleted

[sakal, 2017-02-16 12:36:59]

Patchset #1 (id:40001) has been deleted

[sakal, 2017-02-16 12:37:11]

Patchset #1 (id:60001) has been deleted

[sakal, 2017-02-16 12:37:21]

Patchset #1 (id:80001) has been deleted

[sakal, 2017-02-16 12:42:47]

Description was changed from

==========
Add QP for libvpx VP8 decoder.

BUG=webrtc:6541
==========

to

==========
Add QP for libvpx VP8 decoder.

BUG=webrtc:6541
==========

[sakal, 2017-02-16 12:42:48]

sakal@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sakal, 2017-02-16 12:44:49]

PTAL

https://codereview.webrtc.org/2656603002/diff/100001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right):

https://codereview.webrtc.org/2656603002/diff/100001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1149:
vpx_codec_control(decoder_, VPXD_GET_LAST_QUANTIZER, &qp);
This method can return failure in theory. However, in practice it only happens
if it is not supplied a valid int pointer. I would prefer not adding dead code
for handling this. WDYT?

[sprang_webrtc, 2017-02-17 11:41:31]

looks good, but I'd appreciate a unit test as well

[sakal, 2017-02-17 12:20:34]

On 2017/02/17 11:41:31, språng wrote:
> looks good, but I'd appreciate a unit test as well

Done. PTAL

[sprang_webrtc, 2017-02-17 12:32:00]

lgtm with nits

https://codereview.webrtc.org/2656603002/diff/160001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right):

https://codereview.webrtc.org/2656603002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:257:
encoder_->Encode(*input_frame_, NULL, NULL);
nullptr for all new code

https://codereview.webrtc.org/2656603002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:266:
EXPECT_EQ(encoded_frame_.qp_, *decoded_qp_);
I'd assert decoded_qp_ has a value first, or maybe decoded_qp_.value_or(-1)

[sakal, 2017-02-17 12:41:41]

https://codereview.webrtc.org/2656603002/diff/160001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right):

https://codereview.webrtc.org/2656603002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:257:
encoder_->Encode(*input_frame_, NULL, NULL);
On 2017/02/17 12:31:59, språng wrote:
> nullptr for all new code

Done.

https://codereview.webrtc.org/2656603002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:266:
EXPECT_EQ(encoded_frame_.qp_, *decoded_qp_);
On 2017/02/17 12:31:59, språng wrote:
> I'd assert decoded_qp_ has a value first, or maybe decoded_qp_.value_or(-1)

Done.

[sakal, 2017-02-17 12:41:48]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2017-02-17 12:41:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2656603002/#ps180001 (title:
"Changes according to språng's comments.")

[commit-bot: I haz the power, 2017-02-17 12:42:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-17 12:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 12:43:52]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/18868)
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13618)

[sakal, 2017-02-17 12:50:36]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 12:50:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-17 13:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 13:04:56]

Dry run: Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/22888)

[sakal, 2017-02-17 13:14:33]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 13:14:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-17 13:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 13:42:17]

Dry run: Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/23219)

[sakal, 2017-02-20 12:54:32]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 12:54:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-20 12:56:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 12:56:48]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/5931)

[sakal, 2017-02-20 12:58:39]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 12:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2017-02-20 13:44:01]

Description was changed from

==========
Add QP for libvpx VP8 decoder.

BUG=webrtc:6541
==========

to

==========
Add QP for libvpx VP8 decoder.

BUG=webrtc:6541, webrtc:7065
==========

[sakal, 2017-02-20 13:44:01]

sakal@webrtc.org changed reviewers:
+ hta@webrtc.org

[sakal, 2017-02-20 13:44:34]

hta, PTAL at webrtc/pc/rtcstats_integrationtest.cc

[commit-bot: I haz the power, 2017-02-20 13:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 13:47:52]

Dry run: This issue passed the CQ dry run.

[hbos, 2017-02-20 14:40:01]

hbos@webrtc.org changed reviewers:
+ hbos@webrtc.org

[hbos, 2017-02-20 14:40:02]

hta is OOO, lgtm webrtc/pc/rtcstats_integrationtest.cc

[sakal, 2017-02-20 14:41:29]

Description was changed from

==========
Add QP for libvpx VP8 decoder.

BUG=webrtc:6541, webrtc:7065
==========

to

==========
Add QP for libvpx VP8 decoder.

BUG=webrtc:6541, webrtc:7065
TBR=hta@webrtc.org
==========

[sakal, 2017-02-20 14:41:38]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2017-02-20 14:41:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2656603002/#ps260001 (title:
"Rebase.")

[commit-bot: I haz the power, 2017-02-20 14:41:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-20 14:43:59]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1487601698582850,
"parent_rev": "4228784609afcea28174a673e4a2024b9a75c628", "commit_rev":
"5fec128de94c0b2d0090de8eac692dce9aa23a80"}

[commit-bot: I haz the power, 2017-02-20 14:44:02]

Description was changed from

==========
Add QP for libvpx VP8 decoder.

BUG=webrtc:6541, webrtc:7065
TBR=hta@webrtc.org
==========

to

==========
Add QP for libvpx VP8 decoder.

BUG=webrtc:6541, webrtc:7065
TBR=hta@webrtc.org

Review-Url: https://codereview.webrtc.org/2656603002
Cr-Commit-Position: refs/heads/master@{#16722}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5fec128de94c0b2d0090de8ea...
==========

[commit-bot: I haz the power, 2017-02-20 14:44:03]

Committed patchset #9 (id:260001) as
https://chromium.googlesource.com/external/webrtc/+/5fec128de94c0b2d0090de8ea...