Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2656603002: Add QP for libvpx VP8 decoder. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 verifier->TestMemberIsUndefined(stream.pli_count); 529 verifier->TestMemberIsUndefined(stream.pli_count);
530 verifier->TestMemberIsUndefined(stream.nack_count); 530 verifier->TestMemberIsUndefined(stream.nack_count);
531 } 531 }
532 verifier->TestMemberIsUndefined(stream.sli_count); 532 verifier->TestMemberIsUndefined(stream.sli_count);
533 } 533 }
534 534
535 bool VerifyRTCInboundRTPStreamStats( 535 bool VerifyRTCInboundRTPStreamStats(
536 const RTCInboundRTPStreamStats& inbound_stream) { 536 const RTCInboundRTPStreamStats& inbound_stream) {
537 RTCStatsVerifier verifier(report_, &inbound_stream); 537 RTCStatsVerifier verifier(report_, &inbound_stream);
538 VerifyRTCRTPStreamStats(inbound_stream, &verifier); 538 VerifyRTCRTPStreamStats(inbound_stream, &verifier);
539 // TODO(hbos): As soon as the decoders provide |qp_sum| values, this 539 if (inbound_stream.media_type.is_defined() &&
540 // if-statement needs to be included. https://bugs.webrtc.org/7065 540 *inbound_stream.media_type == "video") {
541 // if (inbound_stream.media_type.is_defined() && 541 verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.qp_sum);
542 // *inbound_stream.media_type == "video") { 542 } else {
543 // verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.qp_sum);
544 // } else {
545 verifier.TestMemberIsUndefined(inbound_stream.qp_sum); 543 verifier.TestMemberIsUndefined(inbound_stream.qp_sum);
546 // } 544 }
547 verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_received); 545 verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_received);
548 verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received); 546 verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received);
549 verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_lost); 547 verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_lost);
550 if (inbound_stream.media_type.is_defined() && 548 if (inbound_stream.media_type.is_defined() &&
551 *inbound_stream.media_type == "video") { 549 *inbound_stream.media_type == "video") {
552 verifier.TestMemberIsUndefined(inbound_stream.jitter); 550 verifier.TestMemberIsUndefined(inbound_stream.jitter);
553 } else { 551 } else {
554 verifier.TestMemberIsNonNegative<double>(inbound_stream.jitter); 552 verifier.TestMemberIsNonNegative<double>(inbound_stream.jitter);
555 } 553 }
556 verifier.TestMemberIsNonNegative<double>(inbound_stream.fraction_lost); 554 verifier.TestMemberIsNonNegative<double>(inbound_stream.fraction_lost);
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 caller_ = nullptr; 641 caller_ = nullptr;
644 // Any pending stats requests should have completed in the act of destroying 642 // Any pending stats requests should have completed in the act of destroying
645 // the peer connection. 643 // the peer connection.
646 EXPECT_TRUE(stats_obtainer->report()); 644 EXPECT_TRUE(stats_obtainer->report());
647 } 645 }
648 #endif // HAVE_SCTP 646 #endif // HAVE_SCTP
649 647
650 } // namespace 648 } // namespace
651 649
652 } // namespace webrtc 650 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698