Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2656533005: Revert of Disabled two iOS tests due to bot breakage. Affected tests are (Closed)

Created:
3 years, 11 months ago by aleloi
Modified:
3 years, 11 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Disabled two iOS tests due to bot breakage. Affected tests are (patchset #1 id:1 of https://codereview.webrtc.org/2652423002/ ) Reason for revert: This was false alarm. The next Chromium roll fixed the problem and the bot has been green for 3 builds. Original issue's description: > Disabled two iOS tests due to bot breakage. Affected tests are > AudioDeviceTest.RunPlayoutWithFileAsSource and > AudioDeviceTest.StartStopRecording > > NOTRY=True > TBR=henrika@webrtc.org > BUG=7056 > > Review-Url: https://codereview.webrtc.org/2652423002 > Cr-Commit-Position: refs/heads/master@{#16286} > Committed: https://chromium.googlesource.com/external/webrtc/+/8e775e16eba1c3d2983f24d3fcf59400f79b9783 TBR=henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=7056 Review-Url: https://codereview.webrtc.org/2656533005 Cr-Commit-Position: refs/heads/master@{#16289} Committed: https://chromium.googlesource.com/external/webrtc/+/f3d622d4ade9364259d8028aee39c68f41c86918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
aleloi
Created Revert of Disabled two iOS tests due to bot breakage. Affected tests are
3 years, 11 months ago (2017-01-26 09:50:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2656533005/1
3 years, 11 months ago (2017-01-26 09:50:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/f3d622d4ade9364259d8028aee39c68f41c86918
3 years, 11 months ago (2017-01-26 09:50:50 UTC) #6
henrika_webrtc
3 years, 11 months ago (2017-01-26 09:54:01 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698