Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2652423002: Disabled two iOS tests due to bot breakage. Affected tests are (Closed)

Created:
3 years, 10 months ago by aleloi
Modified:
3 years, 10 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disabled two iOS tests due to bot breakage. Affected tests are AudioDeviceTest.RunPlayoutWithFileAsSource and AudioDeviceTest.StartStopRecording NOTRY=True TBR=henrika@webrtc.org BUG=7056 Review-Url: https://codereview.webrtc.org/2652423002 Cr-Commit-Position: refs/heads/master@{#16286} Committed: https://chromium.googlesource.com/external/webrtc/+/8e775e16eba1c3d2983f24d3fcf59400f79b9783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2652423002/1
3 years, 10 months ago (2017-01-26 09:03:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/8e775e16eba1c3d2983f24d3fcf59400f79b9783
3 years, 10 months ago (2017-01-26 09:06:13 UTC) #10
aleloi
3 years, 10 months ago (2017-01-26 09:50:31 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2656533005/ by aleloi@webrtc.org.

The reason for reverting is: This was false alarm. The next Chromium roll fixed
the problem and the bot has been green for 3 builds..

Powered by Google App Engine
This is Rietveld 408576698