Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2654753003: Revert of Delete unused class/template ScopedMessageData. (Closed)

Created:
3 years, 11 months ago by aleloi
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete unused class/template ScopedMessageData. (patchset #1 id:1 of https://codereview.webrtc.org/2652663002/ ) Reason for revert: ScopedMessageData can't be removed just yet. It broke an internal project. Original issue's description: > Delete unused class/template ScopedMessageData. > > This appears unused since cl https://codereview.webrtc.org/2564333002 > > BUG=webrtc:6424 > > Review-Url: https://codereview.webrtc.org/2652663002 > Cr-Commit-Position: refs/heads/master@{#16229} > Committed: https://chromium.googlesource.com/external/webrtc/+/d83fb921a855531bfa58f873e2c668bfa735ad09 TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2654753003 Cr-Commit-Position: refs/heads/master@{#16231} Committed: https://chromium.googlesource.com/external/webrtc/+/e04064deb2d7a49493bdeac0c87f7e0aa0fa141c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M webrtc/base/messagequeue.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
aleloi
Created Revert of Delete unused class/template ScopedMessageData.
3 years, 11 months ago (2017-01-24 09:20:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2654753003/1
3 years, 11 months ago (2017-01-24 09:20:35 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 09:20:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e04064deb2d7a49493bdeac0c...

Powered by Google App Engine
This is Rietveld 408576698