Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2652663002: Delete unused class/template ScopedMessageData. (Closed)

Created:
3 years, 11 months ago by nisse-webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused class/template ScopedMessageData. This appears unused since cl https://codereview.webrtc.org/2564333002 BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2652663002 Cr-Commit-Position: refs/heads/master@{#16229} Committed: https://chromium.googlesource.com/external/webrtc/+/d83fb921a855531bfa58f873e2c668bfa735ad09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M webrtc/base/messagequeue.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nisse-webrtc
PTAL. This class appears unused, do you expect it to find any new uses? I ...
3 years, 11 months ago (2017-01-23 13:42:08 UTC) #2
Taylor Brandstetter
lgtm; I think these things can both be deleted. With abstractions like "AsyncInvoker" and "rtc::Bind", ...
3 years, 11 months ago (2017-01-23 18:26:57 UTC) #3
pthatcher1
lgtm
3 years, 11 months ago (2017-01-23 21:35:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2652663002/1
3 years, 11 months ago (2017-01-24 07:51:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d83fb921a855531bfa58f873e2c668bfa735ad09
3 years, 11 months ago (2017-01-24 08:36:42 UTC) #9
aleloi
3 years, 11 months ago (2017-01-24 09:20:24 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2654753003/ by aleloi@webrtc.org.

The reason for reverting is: ScopedMessageData can't be removed just yet. It
broke an internal project..

Powered by Google App Engine
This is Rietveld 408576698