Reland of Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters.

Reland of Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters. (patchset #1 id:1 of https://codereview.webrtc.org/2649323010/ )

Reason for revert:
Downstream project relied on changed struct.

Transition made possible by https://codereview.webrtc.org/2655243006/.

Original issue's description:
> Revert of Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters. (patchset #7 id:160001 of https://codereview.webrtc.org/2646073004/ )
> 
> Reason for revert:
> Breaks internal downstream project.
> 
> Original issue's description:
> > Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters.
> > 
> > Prior to this CL, received RTX (associated) payload types were only configured
> > when WebRtcVideoChannel2::AddRecvStream was called. In the same method, the RTX
> > SSRC was set up.
> > 
> > After this CL, the RTX (associated) payload types are set in
> > WebRtcVideoChannel2::SetRecvParameters, which is the appropriate place to set
> > them. The RTX SSRC is still set in WebRtcVideoChannel2::AddRecvStream, since
> > that is the code path that sets other SSRCs.
> > 
> > As part of this fix, the VideoReceiveStream::Config::Rtp struct is changed.
> > We remove the possibility for each video payload type to have an associated
> > specific RTX SSRC. Although the config previously allowed for this, all payload
> > types always had the same RTX SSRC set, and the underlying RtpPayloadRegistry
> > did not support multiple SSRCs. This change to the config struct should thus not
> > have any functional impact. The change does however affect the RtcEventLog, since
> > that is used for storing the VideoReceiveStream::Configs. For simplicity,
> > this CL does not change the event log proto definitions, instead duplicating
> > the serialized RTX SSRCs such that they fit in the existing proto definition.
> > 
> > BUG=webrtc:7011
> > 
> > Review-Url: https://codereview.webrtc.org/2646073004
> > Cr-Commit-Position: refs/heads/master@{#16302}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/fe2bef39cd2a5c891a49f7320514fb04324dc66c
> 
> TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,brandtr@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7011
> 
> Review-Url: https://codereview.webrtc.org/2649323010
> Cr-Commit-Position: refs/heads/master@{#16307}
> Committed: https://chromium.googlesource.com/external/webrtc/+/e4974953ce0d03a60fae7659b199a6a62a79fa30

TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org,kjellander@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
# NOTREECHECKS=true
# NOTRY=true
BUG=webrtc:7011
Review-Url: https://codereview.webrtc.org/2654163006
Cr-Commit-Position: refs/heads/master@{#16322}
Committed: https://chromium.googlesource.com/external/webrtc/+/14742128957748f5815e85fca829a76f69df5393

[brandtr, 2017-01-27 11:16:04]

Created Reland of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters.

[brandtr, 2017-01-27 11:23:42]

Patchset #2 (id:260001) has been deleted

[brandtr, 2017-01-27 11:24:11]

Rebase.

[brandtr, 2017-01-27 11:27:20]

Description was changed from

==========
Reland of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters. (patchset #1 id:1 of
https://codereview.webrtc.org/2649323010/ )

Reason for revert:
Downstream project relied on changed struct.

Transition made possible by https://codereview.webrtc.org/2655243006/.

Original issue's description:
> Revert of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters. (patchset #7 id:160001 of
https://codereview.webrtc.org/2646073004/ )
> 
> Reason for revert:
> Breaks internal downstream project.
> 
> Original issue's description:
> > Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters.
> > 
> > Prior to this CL, received RTX (associated) payload types were only
configured
> > when WebRtcVideoChannel2::AddRecvStream was called. In the same method, the
RTX
> > SSRC was set up.
> > 
> > After this CL, the RTX (associated) payload types are set in
> > WebRtcVideoChannel2::SetRecvParameters, which is the appropriate place to
set
> > them. The RTX SSRC is still set in WebRtcVideoChannel2::AddRecvStream, since
> > that is the code path that sets other SSRCs.
> > 
> > As part of this fix, the VideoReceiveStream::Config::Rtp struct is changed.
> > We remove the possibility for each video payload type to have an associated
> > specific RTX SSRC. Although the config previously allowed for this, all
payload
> > types always had the same RTX SSRC set, and the underlying
RtpPayloadRegistry
> > did not support multiple SSRCs. This change to the config struct should thus
not
> > have any functional impact. The change does however affect the RtcEventLog,
since
> > that is used for storing the VideoReceiveStream::Configs. For simplicity,
> > this CL does not change the event log proto definitions, instead duplicating
> > the serialized RTX SSRCs such that they fit in the existing proto
definition.
> > 
> > BUG=webrtc:7011
> > 
> > Review-Url: https://codereview.webrtc.org/2646073004
> > Cr-Commit-Position: refs/heads/master@{#16302}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/fe2bef39cd2a5c891a49f7320...
> 
> TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,brandtr@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7011
> 
> Review-Url: https://codereview.webrtc.org/2649323010
> Cr-Commit-Position: refs/heads/master@{#16307}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/e4974953ce0d03a60fae7659b...

TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,kjellander@webrtc...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7011
==========

to

==========
Reland of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters. (patchset #1 id:1 of
https://codereview.webrtc.org/2649323010/ )

Reason for revert:
Downstream project relied on changed struct.

Transition made possible by https://codereview.webrtc.org/2655243006/.

Original issue's description:
> Revert of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters. (patchset #7 id:160001 of
https://codereview.webrtc.org/2646073004/ )
> 
> Reason for revert:
> Breaks internal downstream project.
> 
> Original issue's description:
> > Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters.
> > 
> > Prior to this CL, received RTX (associated) payload types were only
configured
> > when WebRtcVideoChannel2::AddRecvStream was called. In the same method, the
RTX
> > SSRC was set up.
> > 
> > After this CL, the RTX (associated) payload types are set in
> > WebRtcVideoChannel2::SetRecvParameters, which is the appropriate place to
set
> > them. The RTX SSRC is still set in WebRtcVideoChannel2::AddRecvStream, since
> > that is the code path that sets other SSRCs.
> > 
> > As part of this fix, the VideoReceiveStream::Config::Rtp struct is changed.
> > We remove the possibility for each video payload type to have an associated
> > specific RTX SSRC. Although the config previously allowed for this, all
payload
> > types always had the same RTX SSRC set, and the underlying
RtpPayloadRegistry
> > did not support multiple SSRCs. This change to the config struct should thus
not
> > have any functional impact. The change does however affect the RtcEventLog,
since
> > that is used for storing the VideoReceiveStream::Configs. For simplicity,
> > this CL does not change the event log proto definitions, instead duplicating
> > the serialized RTX SSRCs such that they fit in the existing proto
definition.
> > 
> > BUG=webrtc:7011
> > 
> > Review-Url: https://codereview.webrtc.org/2646073004
> > Cr-Commit-Position: refs/heads/master@{#16302}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/fe2bef39cd2a5c891a49f7320...
> 
> TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,brandtr@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7011
> 
> Review-Url: https://codereview.webrtc.org/2649323010
> Cr-Commit-Position: refs/heads/master@{#16307}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/e4974953ce0d03a60fae7659b...

TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,kjellander@webrtc...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
# NOTREECHECKS=true
# NOTRY=true
BUG=webrtc:7011
==========

[brandtr, 2017-01-27 12:00:43]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 12:00:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2017-01-27 12:09:56]

lgtm

[commit-bot: I haz the power, 2017-01-27 12:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 12:51:51]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-01-27 12:52:46]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-01-27 12:52:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-27 12:53:08]

CQ is committing da patch.

Bot data: {"patchset_id": 300001, "attempt_start_ts": 1485521566611110,
"parent_rev": "986012d346ef0df64fbc9a2a1b325b8263944544", "commit_rev":
"14742128957748f5815e85fca829a76f69df5393"}

[commit-bot: I haz the power, 2017-01-27 12:53:12]

Description was changed from

==========
Reland of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters. (patchset #1 id:1 of
https://codereview.webrtc.org/2649323010/ )

Reason for revert:
Downstream project relied on changed struct.

Transition made possible by https://codereview.webrtc.org/2655243006/.

Original issue's description:
> Revert of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters. (patchset #7 id:160001 of
https://codereview.webrtc.org/2646073004/ )
> 
> Reason for revert:
> Breaks internal downstream project.
> 
> Original issue's description:
> > Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters.
> > 
> > Prior to this CL, received RTX (associated) payload types were only
configured
> > when WebRtcVideoChannel2::AddRecvStream was called. In the same method, the
RTX
> > SSRC was set up.
> > 
> > After this CL, the RTX (associated) payload types are set in
> > WebRtcVideoChannel2::SetRecvParameters, which is the appropriate place to
set
> > them. The RTX SSRC is still set in WebRtcVideoChannel2::AddRecvStream, since
> > that is the code path that sets other SSRCs.
> > 
> > As part of this fix, the VideoReceiveStream::Config::Rtp struct is changed.
> > We remove the possibility for each video payload type to have an associated
> > specific RTX SSRC. Although the config previously allowed for this, all
payload
> > types always had the same RTX SSRC set, and the underlying
RtpPayloadRegistry
> > did not support multiple SSRCs. This change to the config struct should thus
not
> > have any functional impact. The change does however affect the RtcEventLog,
since
> > that is used for storing the VideoReceiveStream::Configs. For simplicity,
> > this CL does not change the event log proto definitions, instead duplicating
> > the serialized RTX SSRCs such that they fit in the existing proto
definition.
> > 
> > BUG=webrtc:7011
> > 
> > Review-Url: https://codereview.webrtc.org/2646073004
> > Cr-Commit-Position: refs/heads/master@{#16302}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/fe2bef39cd2a5c891a49f7320...
> 
> TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,brandtr@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7011
> 
> Review-Url: https://codereview.webrtc.org/2649323010
> Cr-Commit-Position: refs/heads/master@{#16307}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/e4974953ce0d03a60fae7659b...

TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,kjellander@webrtc...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
# NOTREECHECKS=true
# NOTRY=true
BUG=webrtc:7011
==========

to

==========
Reland of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters. (patchset #1 id:1 of
https://codereview.webrtc.org/2649323010/ )

Reason for revert:
Downstream project relied on changed struct.

Transition made possible by https://codereview.webrtc.org/2655243006/.

Original issue's description:
> Revert of Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters. (patchset #7 id:160001 of
https://codereview.webrtc.org/2646073004/ )
> 
> Reason for revert:
> Breaks internal downstream project.
> 
> Original issue's description:
> > Make RTX pt/apt reconfigurable by calling
WebRtcVideoChannel2::SetRecvParameters.
> > 
> > Prior to this CL, received RTX (associated) payload types were only
configured
> > when WebRtcVideoChannel2::AddRecvStream was called. In the same method, the
RTX
> > SSRC was set up.
> > 
> > After this CL, the RTX (associated) payload types are set in
> > WebRtcVideoChannel2::SetRecvParameters, which is the appropriate place to
set
> > them. The RTX SSRC is still set in WebRtcVideoChannel2::AddRecvStream, since
> > that is the code path that sets other SSRCs.
> > 
> > As part of this fix, the VideoReceiveStream::Config::Rtp struct is changed.
> > We remove the possibility for each video payload type to have an associated
> > specific RTX SSRC. Although the config previously allowed for this, all
payload
> > types always had the same RTX SSRC set, and the underlying
RtpPayloadRegistry
> > did not support multiple SSRCs. This change to the config struct should thus
not
> > have any functional impact. The change does however affect the RtcEventLog,
since
> > that is used for storing the VideoReceiveStream::Configs. For simplicity,
> > this CL does not change the event log proto definitions, instead duplicating
> > the serialized RTX SSRCs such that they fit in the existing proto
definition.
> > 
> > BUG=webrtc:7011
> > 
> > Review-Url: https://codereview.webrtc.org/2646073004
> > Cr-Commit-Position: refs/heads/master@{#16302}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/fe2bef39cd2a5c891a49f7320...
> 
> TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,brandtr@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7011
> 
> Review-Url: https://codereview.webrtc.org/2649323010
> Cr-Commit-Position: refs/heads/master@{#16307}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/e4974953ce0d03a60fae7659b...

TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,kjellander@webrtc...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
# NOTREECHECKS=true
# NOTRY=true
BUG=webrtc:7011

Review-Url: https://codereview.webrtc.org/2654163006
Cr-Commit-Position: refs/heads/master@{#16322}
Committed:
https://chromium.googlesource.com/external/webrtc/+/14742128957748f5815e85fca...
==========

[commit-bot: I haz the power, 2017-01-27 12:53:13]

Committed patchset #3 (id:300001) as
https://chromium.googlesource.com/external/webrtc/+/14742128957748f5815e85fca...