Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2649323010: Revert of Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters. (Closed)

Created:
3 years, 10 months ago by kjellander (google.com)
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters. (patchset #7 id:160001 of https://codereview.webrtc.org/2646073004/ ) Reason for revert: Breaks internal downstream project. Original issue's description: > Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters. > > Prior to this CL, received RTX (associated) payload types were only configured > when WebRtcVideoChannel2::AddRecvStream was called. In the same method, the RTX > SSRC was set up. > > After this CL, the RTX (associated) payload types are set in > WebRtcVideoChannel2::SetRecvParameters, which is the appropriate place to set > them. The RTX SSRC is still set in WebRtcVideoChannel2::AddRecvStream, since > that is the code path that sets other SSRCs. > > As part of this fix, the VideoReceiveStream::Config::Rtp struct is changed. > We remove the possibility for each video payload type to have an associated > specific RTX SSRC. Although the config previously allowed for this, all payload > types always had the same RTX SSRC set, and the underlying RtpPayloadRegistry > did not support multiple SSRCs. This change to the config struct should thus not > have any functional impact. The change does however affect the RtcEventLog, since > that is used for storing the VideoReceiveStream::Configs. For simplicity, > this CL does not change the event log proto definitions, instead duplicating > the serialized RTX SSRCs such that they fit in the existing proto definition. > > BUG=webrtc:7011 > > Review-Url: https://codereview.webrtc.org/2646073004 > Cr-Commit-Position: refs/heads/master@{#16302} > Committed: https://chromium.googlesource.com/external/webrtc/+/fe2bef39cd2a5c891a49f7320514fb04324dc66c TBR=stefan@webrtc.org,magjed@webrtc.org,terelius@webrtc.org,brandtr@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7011 Review-Url: https://codereview.webrtc.org/2649323010 Cr-Commit-Position: refs/heads/master@{#16307} Committed: https://chromium.googlesource.com/external/webrtc/+/e4974953ce0d03a60fae7659b199a6a62a79fa30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -180 lines) Patch
M webrtc/call/call.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/call/rampup_tests.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 2 chunks +5 lines, -20 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 6 chunks +15 lines, -90 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/video_receive_stream.h View 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander (google.com)
Created Revert of Make RTX pt/apt reconfigurable by calling WebRtcVideoChannel2::SetRecvParameters.
3 years, 10 months ago (2017-01-26 21:20:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2649323010/1
3 years, 10 months ago (2017-01-26 21:21:01 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-26 21:21:03 UTC) #5
kjellander_webrtc
ah, wrong account again. lgtm with my webrtc.org account
3 years, 10 months ago (2017-01-26 21:22:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2649323010/1
3 years, 10 months ago (2017-01-26 21:22:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/e4974953ce0d03a60fae7659b199a6a62a79fa30
3 years, 10 months ago (2017-01-26 21:22:42 UTC) #13
brandtr
3 years, 10 months ago (2017-01-27 11:16:03 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2654163006/ by brandtr@webrtc.org.

The reason for reverting is: Downstream project relied on changed struct.

Transition made possible by https://codereview.webrtc.org/2655243006/..

Powered by Google App Engine
This is Rietveld 408576698