Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: webrtc/base/BUILD.gn

Issue 2647663002: Delete or update left-over ASSERT use and comments. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/base/fileutils.h » ('j') | webrtc/base/fileutils.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/crypto.gni") 9 import("//build/config/crypto.gni")
10 import("//build/config/ui.gni") 10 import("//build/config/ui.gni")
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 defines += [ "_CRT_NONSTDC_NO_DEPRECATE" ] 658 defines += [ "_CRT_NONSTDC_NO_DEPRECATE" ]
659 } 659 }
660 660
661 if (is_posix) { 661 if (is_posix) {
662 sources += [ 662 sources += [
663 "ifaddrs_converter.cc", 663 "ifaddrs_converter.cc",
664 "ifaddrs_converter.h", 664 "ifaddrs_converter.h",
665 "unixfilesystem.cc", 665 "unixfilesystem.cc",
666 "unixfilesystem.h", 666 "unixfilesystem.h",
667 ] 667 ]
668 if (is_debug) {
669 # The Chromium build/common.gypi defines this for all posix
670 # _except_ for ios & mac. We want it there as well, e.g.
671 # because ASSERT and friends trigger off of it.
672 defines += [ "_DEBUG" ]
673 }
kwiberg-webrtc 2017/01/23 12:25:14 Curiously, _DEBUG seems to be a Windows thing, not
nisse-webrtc 2017/01/23 12:53:03 I've search history, _DEBUG was used in lots of pl
674 } 668 }
675 669
676 if (is_nacl) { 670 if (is_nacl) {
677 deps += [ "//native_client_sdk/src/libraries/nacl_io" ] 671 deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
678 defines += [ "timezone=_timezone" ] 672 defines += [ "timezone=_timezone" ]
679 sources -= [ "ifaddrs_converter.cc" ] 673 sources -= [ "ifaddrs_converter.cc" ]
680 } 674 }
681 if (is_win && is_clang) { 675 if (is_win && is_clang) {
682 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 676 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
683 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 677 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
944 938
945 if (is_android) { 939 if (is_android) {
946 android_library("base_java") { 940 android_library("base_java") {
947 java_files = [ 941 java_files = [
948 "java/src/org/webrtc/Logging.java", 942 "java/src/org/webrtc/Logging.java",
949 "java/src/org/webrtc/Size.java", 943 "java/src/org/webrtc/Size.java",
950 "java/src/org/webrtc/ThreadUtils.java", 944 "java/src/org/webrtc/ThreadUtils.java",
951 ] 945 ]
952 } 946 }
953 } 947 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/base/fileutils.h » ('j') | webrtc/base/fileutils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698