Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2645033002: Remove VoEExternalMedia interface. (Closed)

Created:
3 years, 11 months ago by the sun
Modified:
3 years, 10 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoEExternalMedia interface. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2645033002 Cr-Commit-Position: refs/heads/master@{#16608} Committed: https://chromium.googlesource.com/external/webrtc/+/e374e0139bc387b890fa7164ed3a9929e06bbb25

Patch Set 1 #

Patch Set 2 : forgot a few lines #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -853 lines) Patch
M webrtc/common_types.h View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/test/mock_voice_engine.h View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 3 4 chunks +0 lines, -5 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 7 chunks +0 lines, -18 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 9 chunks +12 lines, -129 lines 0 comments Download
D webrtc/voice_engine/include/voe_external_media.h View 1 chunk +0 lines, -85 lines 0 comments Download
M webrtc/voice_engine/output_mixer.h View 1 2 4 chunks +0 lines, -10 lines 0 comments Download
M webrtc/voice_engine/output_mixer.cc View 1 2 5 chunks +0 lines, -51 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/fakes/fake_media_process.h View 1 chunk +0 lines, -45 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/standard/external_media_test.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.h View 1 2 3 3 chunks +1 line, -3 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_defines.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 4 chunks +0 lines, -6 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 3 chunks +0 lines, -11 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 7 chunks +0 lines, -70 lines 0 comments Download
D webrtc/voice_engine/transmit_mixer_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/voice_engine/voe_external_media_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/voice_engine/voe_external_media_impl.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
the sun
3 years, 10 months ago (2017-02-11 10:19:43 UTC) #4
kwiberg-webrtc
lgtm
3 years, 10 months ago (2017-02-13 14:04:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2645033002/80001
3 years, 10 months ago (2017-02-14 12:35:42 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 12:55:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/e374e0139bc387b890fa7164e...

Powered by Google App Engine
This is Rietveld 408576698