Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: webrtc/voice_engine/output_mixer.cc

Issue 2645033002: Remove VoEExternalMedia interface. (Closed)
Patch Set: bad merge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/output_mixer.h ('k') | webrtc/voice_engine/test/auto_test/fakes/fake_media_process.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/output_mixer.cc
diff --git a/webrtc/voice_engine/output_mixer.cc b/webrtc/voice_engine/output_mixer.cc
index 61babd2750b363b4a04793531bb898dd835cf3ba..5257a639cabfb74d7626c1105e653aa8c3b7c7df 100644
--- a/webrtc/voice_engine/output_mixer.cc
+++ b/webrtc/voice_engine/output_mixer.cc
@@ -15,7 +15,6 @@
#include "webrtc/modules/audio_processing/include/audio_processing.h"
#include "webrtc/system_wrappers/include/file_wrapper.h"
#include "webrtc/system_wrappers/include/trace.h"
-#include "webrtc/voice_engine/include/voe_external_media.h"
#include "webrtc/voice_engine/statistics.h"
#include "webrtc/voice_engine/utility.h"
@@ -94,8 +93,6 @@ OutputMixer::OutputMixer(uint32_t instanceId) :
_mixerModule(*AudioConferenceMixer::Create(instanceId)),
_audioLevel(),
_instanceId(instanceId),
- _externalMediaCallbackPtr(NULL),
- _externalMedia(false),
_panLeft(1.0f),
_panRight(1.0f),
_mixingFrequencyHz(8000),
@@ -126,10 +123,6 @@ OutputMixer::~OutputMixer()
{
WEBRTC_TRACE(kTraceMemory, kTraceVoice, VoEId(_instanceId,-1),
"OutputMixer::~OutputMixer() - dtor");
- if (_externalMedia)
- {
- DeRegisterExternalMediaProcessing();
- }
{
rtc::CritScope cs(&_fileCritSect);
if (output_file_recorder_) {
@@ -160,31 +153,6 @@ OutputMixer::SetAudioProcessingModule(AudioProcessing* audioProcessingModule)
return 0;
}
-int OutputMixer::RegisterExternalMediaProcessing(
- VoEMediaProcess& proccess_object)
-{
- WEBRTC_TRACE(kTraceInfo, kTraceVoice, VoEId(_instanceId,-1),
- "OutputMixer::RegisterExternalMediaProcessing()");
-
- rtc::CritScope cs(&_callbackCritSect);
- _externalMediaCallbackPtr = &proccess_object;
- _externalMedia = true;
-
- return 0;
-}
-
-int OutputMixer::DeRegisterExternalMediaProcessing()
-{
- WEBRTC_TRACE(kTraceInfo, kTraceVoice, VoEId(_instanceId,-1),
- "OutputMixer::DeRegisterExternalMediaProcessing()");
-
- rtc::CritScope cs(&_callbackCritSect);
- _externalMedia = false;
- _externalMediaCallbackPtr = NULL;
-
- return 0;
-}
-
int32_t
OutputMixer::SetMixabilityStatus(MixerParticipant& participant,
bool mixable)
@@ -479,25 +447,6 @@ OutputMixer::DoOperationsOnCombinedSignal(bool feed_data_to_apm)
}
}
- // --- External media processing
- {
- rtc::CritScope cs(&_callbackCritSect);
- if (_externalMedia)
- {
- const bool is_stereo = (_audioFrame.num_channels_ == 2);
- if (_externalMediaCallbackPtr)
- {
- _externalMediaCallbackPtr->Process(
- -1,
- kPlaybackAllChannelsMixed,
- (int16_t*)_audioFrame.data_,
- _audioFrame.samples_per_channel_,
- _audioFrame.sample_rate_hz_,
- is_stereo);
- }
- }
- }
-
// --- Measure audio level (0-9) for the combined signal
_audioLevel.ComputeLevel(_audioFrame);
« no previous file with comments | « webrtc/voice_engine/output_mixer.h ('k') | webrtc/voice_engine/test/auto_test/fakes/fake_media_process.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698