Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2642783006: Move implmentation specific constants out of rtp_header_extension.h (Closed)

Created:
3 years, 11 months ago by danilchap
Modified:
3 years, 11 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move implmentation specific constants out of rtp_header_extension.h BUG=None Review-Url: https://codereview.webrtc.org/2642783006 Cr-Commit-Position: refs/heads/master@{#16222} Committed: https://chromium.googlesource.com/external/webrtc/+/5c4f24a141272948d4f763ffdb1738bfbe5ac18e

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M webrtc/modules/rtp_rtcp/source/playout_delay_oracle.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.h View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
danilchap
3 years, 11 months ago (2017-01-19 13:12:05 UTC) #9
sprang_webrtc
Nice! lgtm
3 years, 11 months ago (2017-01-23 12:39:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2642783006/60001
3 years, 11 months ago (2017-01-23 12:39:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/17898) win_clang_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-23 12:40:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2642783006/60001
3 years, 11 months ago (2017-01-23 18:35:34 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 19:10:25 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/5c4f24a141272948d4f763ffd...

Powered by Google App Engine
This is Rietveld 408576698