webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc - Issue 2642783006: Move implmentation specific constants out of rtp_header_extension.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc

Issue 2642783006: Move implmentation specific constants out of rtp_header_extension.h (Closed)

Patch Set: . Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc

index 81f052695443cb40aeba6ebf8313e132358ab824..179d27985fc36ce86c952df1f96b72f56976c440 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc

@@ -87,6 +87,7 @@ TEST(RtpHeaderExtensionTest, GetTotalLength) {

RtpHeaderExtensionMap map;

EXPECT_EQ(0u, map.GetTotalLengthInBytes());

EXPECT_TRUE(map.Register<TransmissionOffset>(3));

+ static constexpr size_t kRtpOneByteHeaderLength = 4;

EXPECT_EQ(kRtpOneByteHeaderLength + (TransmissionOffset::kValueSizeBytes + 1),

map.GetTotalLengthInBytes());

}